Modularization of scripts - #3
Open
JavierCoronel wants to merge 5 commits into
Open
Conversation
As they were previously overflooked and resulted in formatting errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I found the repository after realizing BR charges for converting epubs...
Thanks for the code, it works like a charm!
I worked a bit on the code to make it more modularized and readable. Also uses the
firemodule to simply use arguments from the console.I added a bit of refactoring for generating the bold text and it works now on specific tokens of the text. This will help for instance for special characters and word contractions like We're, I'm and so on