Skip to content

improve unit test for TagCollector #12472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LinaresToine wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improve unit test for TagCollector #12472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/python/WMCore/Services/TagCollector/TagCollector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
standard_library.install_aliases()

import logging
from os import path
import os
from urllib.parse import urlparse

from collections import defaultdict
Expand Down Expand Up @@ -143,7 +143,7 @@ def _getResult(self, callname="", clearCache=False,
except Exception:
logging.error('Something went wrong accessing ReleasesXML from cmssdt, perhaps the service is temporarily down')
logging.info('Checking if cvmfs is mounted')
cvmfsMounted = path.ismount('/cvmfs')
cvmfsMounted = os.path.ismount('/cvmfs')
if cvmfsMounted:
logging.info('cvmfs is mounted. Retrying to access ReleasesXML from cvmfs')
try:
Expand Down
4 changes: 1 addition & 3 deletions test/python/WMCore_t/Services_t/TagCollector_t/TagCollector_t.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ def _getResult(self, testReleasesMap=None, testReleasesXML=None):
except Exception:
logging.error('Something went wrong parsing the test releasesMap into the sample XML file')
raise

return result

def data(self, testReleasesMap=None, testReleasesXML=None):
Expand Down Expand Up @@ -71,7 +70,7 @@ def releases(self, arch=None, testReleasesMap=None, testReleasesXML=None):
arr.append(item['label'])
return list(set(arr))

def architectures(self, arch=None, testReleasesMap=None, testReleasesXML=None):
def architectures(self, testReleasesMap=None, testReleasesXML=None):
"""
_architectures_

Expand Down Expand Up @@ -142,7 +141,6 @@ def testTagCollecorMethods(self):
self.assertEqual(len(architecturesCvmfs), len(realsese_by_arch_cvmfs))
self.assertEqual(sorted(self.releases(arch='el8_amd64_gcc12', testReleasesMap=self.testReleasesMap, testReleasesXML=self.testReleasesXML)),
sorted(realsese_by_arch_cvmfs.get('el8_amd64_gcc12')))

return

if __name__ == '__main__':
Expand Down