Add a first level fix for missing iam_group type.#11496
Open
todor-ivanov wants to merge 1 commit intodmwm:masterfrom
Open
Add a first level fix for missing iam_group type.#11496todor-ivanov wants to merge 1 commit intodmwm:masterfrom
todor-ivanov wants to merge 1 commit intodmwm:masterfrom
Conversation
|
Jenkins results:
|
vkuznet
approved these changes
Feb 24, 2023
amaltaro
reviewed
Feb 24, 2023
Contributor
amaltaro
left a comment
amaltaro
left a comment
There was a problem hiding this comment.
Todor, as we discussed over Slack today, before making any further changes to this REST/authz layer, I would rather wait to see what are the requirements going to be for the token evolution.
My understanding was that Panos would get back to this in the coming week(s). I am not seriously against merging this though, but I would avoid changes that might change again in the coming weeks.
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11495
Status
In development
Description
Adding a new group type to the user's attributes as an initial quick fix. So far those are not checked anywhere in the code.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
None
External dependencies / deployment changes
None