Feat/totalseg liver lesion task#11
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1cc784ec4b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if expected_paths and all(dst.exists() for dst in expected_paths) and not force: | ||
| if verbose: | ||
| logger.info("Skip %s – files exist", task_name) |
There was a problem hiding this comment.
In segment_volume, the skip-fast path only runs when expected_paths is non-empty, but tasks without declared outputs now set expected_paths to []. That makes these tasks run on every invocation even with force=False; with this commit, the generic manifest adds liver_segments without outputs, so repeated/resumed runs will re-run heavy segmentation and overwrite existing masks instead of skipping completed work. This is a significant runtime regression and breaks the expected --force behavior for those tasks.
Useful? React with 👍 / 👎.
1 participant
Adds support for the liver lesion segmentation task (https://doi.org/10.1007/s10278-025-01716-y) in the TotalSegmentator workflow.