fix: delete dead code#31
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR removes numerous crates (btress_api, btress_http, daybook_api, daybook_fuse, daybook_http, daybook_server, daybook_willow, daybook_xilem, granary_web app logic, macros, wash_plugin_mltools, wash_plugin_pglite, tests_http) along with their manifests, migrations, WIT definitions, and tests, prunes workspace membership/dependencies accordingly, unwires mltools/utils plugins from daybook_core's runtime, refactors a Gradle Android signing validation task into a typed class, adjusts parse_hledger.rs argument passing, and updates CONTRIBUTING.md. ChangesWorkspace, Plugin, and Crate Removal
granary_web Entrypoint Cleanup
CONTRIBUTING.md Documentation Updates
Android Signing Validation Refactor
Facet Creation Argument Cleanup
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CONTRIBUTING.md`:
- Around line 82-87: The “Dead code” subsection in CONTRIBUTING.md is mixing a
live workspace path with a removed one, so update the list to only include paths
that are actually deleted or rename the section to clearly indicate it is
historical cleanup; use the existing “Dead code” heading and the
`./src/daybook_wflows/` / `./src/daybook_sql/` entries as the points to revise.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9f84bf52-7935-469d-9af6-e55eec830b1f
⛔ Files ignored due to path filters (85)
Cargo.lockis excluded by!**/*.lockand included by**/*src/btress_api/gen/mod.rsis excluded by!**/gen/**and included by**/*src/btress_api/wasmcloud.lockis excluded by!**/*.lockand included by**/*src/btress_api/wit/deps/api-utilsis excluded by!**/*/wit/deps/**and included by**/*src/btress_api/wit/deps/wasi-clocks-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/btress_api/wit/deps/wasi-config-0.2.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/btress_api/wit/deps/wasi-io-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/btress_api/wit/deps/wasi-keyvalue-0.2.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/btress_api/wit/deps/wasi-logging-0.1.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/btress_api/wit/deps/wasmcloud-postgres-0.1.1-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/btress_http/wasmcloud.lockis excluded by!**/*.lockand included by**/*src/btress_http/wit/deps/api-utilsis excluded by!**/*/wit/deps/**and included by**/*src/btress_http/wit/deps/btress-apiis excluded by!**/*/wit/deps/**and included by**/*src/btress_http/wit/deps/wasi-cli-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/btress_http/wit/deps/wasi-clocks-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/btress_http/wit/deps/wasi-config-0.2.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/btress_http/wit/deps/wasi-http-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/btress_http/wit/deps/wasi-io-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/btress_http/wit/deps/wasi-keyvalue-0.2.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/btress_http/wit/deps/wasi-logging-0.1.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/btress_http/wit/deps/wasi-random-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/btress_http/wit/deps/wasmcloud-postgres-0.1.1-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/daybook_api/gen/mod.rsis excluded by!**/gen/**and included by**/*src/daybook_api/wit/deps/api-utilsis excluded by!**/*/wit/deps/**and included by**/*src/daybook_api/wit/deps/daybook-typesis excluded by!**/*/wit/deps/**and included by**/*src/daybook_api/wit/deps/wasi-clocks-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/daybook_api/wit/deps/wasi-config-0.2.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/daybook_api/wit/deps/wasi-io-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/daybook_api/wit/deps/wasi-keyvalue-0.2.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/daybook_api/wit/deps/wasi-logging-0.1.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/daybook_api/wit/deps/wasmcloud-postgres-0.1.1-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/daybook_http/gen/mod.rsis excluded by!**/gen/**and included by**/*src/daybook_http/wasmcloud.lockis excluded by!**/*.lockand included by**/*src/daybook_http/wit/deps/api-utilsis excluded by!**/*/wit/deps/**and included by**/*src/daybook_http/wit/deps/daybook-apiis excluded by!**/*/wit/deps/**and included by**/*src/daybook_http/wit/deps/wasi-cli-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/daybook_http/wit/deps/wasi-clocks-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/daybook_http/wit/deps/wasi-config-0.2.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/daybook_http/wit/deps/wasi-http-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/daybook_http/wit/deps/wasi-io-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/daybook_http/wit/deps/wasi-keyvalue-0.2.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/daybook_http/wit/deps/wasi-logging-0.1.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/daybook_http/wit/deps/wasi-random-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/daybook_http/wit/deps/wasmcloud-postgres-0.1.1-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/daybook_server/gen/mod.rsis excluded by!**/gen/**and included by**/*src/wash_plugin_mltools/wit/deps/api-utilsis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_mltools/wit/deps/mltoolsis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_mltools/wit/deps/wasi-cli-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_mltools/wit/deps/wasi-clocks-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_mltools/wit/deps/wasi-config-0.2.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_mltools/wit/deps/wasi-http-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_mltools/wit/deps/wasi-io-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_mltools/wit/deps/wasi-keyvalue-0.2.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_mltools/wit/deps/wasi-logging-0.1.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_mltools/wit/deps/wasi-random-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_mltools/wit/deps/wasmcloud-postgres-0.1.1-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_pglite/wit/deps/wasi-cli-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_pglite/wit/deps/wasi-clocks-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_pglite/wit/deps/wasi-config-0.2.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_pglite/wit/deps/wasi-http-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_pglite/wit/deps/wasi-io-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_pglite/wit/deps/wasi-keyvalue-0.2.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_pglite/wit/deps/wasi-logging-0.1.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_pglite/wit/deps/wasi-random-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_utils/wit/deps/api-utilsis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_utils/wit/deps/wasi-cli-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_utils/wit/deps/wasi-clocks-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_utils/wit/deps/wasi-config-0.2.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_utils/wit/deps/wasi-http-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_utils/wit/deps/wasi-io-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_utils/wit/deps/wasi-keyvalue-0.2.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_utils/wit/deps/wasi-logging-0.1.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_utils/wit/deps/wasi-random-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wash_plugin_utils/wit/deps/wasmcloud-postgres-0.1.1-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wflow_ingress_http/wit/deps/api-utilsis excluded by!**/*/wit/deps/**and included by**/*src/wflow_ingress_http/wit/deps/wasi-cli-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wflow_ingress_http/wit/deps/wasi-clocks-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wflow_ingress_http/wit/deps/wasi-config-0.2.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wflow_ingress_http/wit/deps/wasi-http-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wflow_ingress_http/wit/deps/wasi-io-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wflow_ingress_http/wit/deps/wasi-keyvalue-0.2.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wflow_ingress_http/wit/deps/wasi-logging-0.1.0-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wflow_ingress_http/wit/deps/wasi-random-0.2.6/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wflow_ingress_http/wit/deps/wasmcloud-postgres-0.1.1-draft/package.witis excluded by!**/*/wit/deps/**and included by**/*src/wflow_ingress_http/wit/deps/wflowis excluded by!**/*/wit/deps/**and included by**/*
📒 Files selected for processing (107)
CONTRIBUTING.mdCargo.tomlsrc/.env.testsrc/btress_api/Cargo.tomlsrc/btress_api/fixtures/000_test_data.sqlsrc/btress_api/lib.rssrc/btress_api/migrations/r__auth_user_functions.sqlsrc/btress_api/migrations/versioned/m0.0.1__utils.sqlsrc/btress_api/migrations/versioned/m0.0.2__create_auth_tables.sqlsrc/btress_api/migrations/versioned/m0.0.3__create_web_table.sqlsrc/btress_api/user.rssrc/btress_api/user/create.rssrc/btress_api/wasmcloud.tomlsrc/btress_api/wit/package.witsrc/btress_api/wit/user.witsrc/btress_http/Cargo.tomlsrc/btress_http/lib.rssrc/btress_http/local.wadm.yamlsrc/btress_http/request.rssrc/btress_http/wadm.yamlsrc/btress_http/wasmcloud.tomlsrc/btress_http/wit/world.witsrc/daybook_api/Cargo.tomlsrc/daybook_api/bindings.rssrc/daybook_api/doc.rssrc/daybook_api/doc/create.rssrc/daybook_api/fixtures/000_test_data.sqlsrc/daybook_api/lib.rssrc/daybook_api/migrations/r__doc_doc_functions.sqlsrc/daybook_api/migrations/versioned/m0.0.1__utils.sqlsrc/daybook_api/migrations/versioned/m0.0.2__create_doc_tables.sqlsrc/daybook_api/wasmcloud.tomlsrc/daybook_api/wit/doc.witsrc/daybook_api/wit/package.witsrc/daybook_core/Cargo.tomlsrc/daybook_core/rt.rssrc/daybook_fuse/Cargo.tomlsrc/daybook_fuse/lib.rssrc/daybook_http/Cargo.tomlsrc/daybook_http/doc.rssrc/daybook_http/doc/create.rssrc/daybook_http/lib.rssrc/daybook_http/local.wadm.yamlsrc/daybook_http/request.rssrc/daybook_http/wadm.yamlsrc/daybook_http/wasmcloud.tomlsrc/daybook_http/wit/world.witsrc/daybook_server/Cargo.tomlsrc/daybook_server/main.rssrc/daybook_wflows/lib.rssrc/daybook_willow/Cargo.tomlsrc/daybook_willow/lib.rssrc/daybook_willow/store.rssrc/daybook_xilem/Cargo.tomlsrc/granary_web/.gitignoresrc/granary_web/Cargo.tomlsrc/granary_web/app.rssrc/granary_web/app/layout.rssrc/granary_web/index.htmlsrc/granary_web/lib.rssrc/granary_web/main.rssrc/macros/Cargo.tomlsrc/macros/lib.rssrc/mltools/lib.rssrc/plug_dayledger/lib.rssrc/plug_plabels/lib.rssrc/plug_test/lib.rssrc/test_wflows/lib.rssrc/tests_http/Cargo.tomlsrc/tests_http/daybook.rssrc/tests_http/daybook/doc.rssrc/tests_http/daybook/doc/create.rssrc/tests_http/lib.rssrc/tests_http/macros.rssrc/tests_http/pg.rssrc/tests_http/sanity_http.rssrc/tests_http/wasmcloud.rssrc/wash_plugin_mltools/Cargo.tomlsrc/wash_plugin_mltools/lib.rssrc/wash_plugin_mltools/wit/main.witsrc/wash_plugin_pglite/Cargo.tomlsrc/wash_plugin_pglite/build.rssrc/wash_plugin_pglite/install.rssrc/wash_plugin_pglite/lib.rssrc/wash_plugin_pglite/parse.rssrc/wash_plugin_pglite/plugin.rssrc/wash_plugin_pglite/wire.rssrc/wash_plugin_pglite/wit/main.witsrc/wash_plugin_utils/Cargo.tomlsrc/wash_plugin_utils/lib.rssrc/wash_plugin_utils/wit/main.witsrc/wflow_ingress_http/Cargo.tomlsrc/wflow_ingress_http/lib.rssrc/wflow_ingress_http/request.rssrc/wflow_ingress_http/wit/main.witsrc/wflow_sdk/lib.rssrc/wflow_webui/Cargo.tomlsrc/wflow_webui/app.rssrc/wflow_webui/auth/actions.rssrc/wflow_webui/auth/mod.rssrc/wflow_webui/index.htmlsrc/wflow_webui/lib.rssrc/wflow_webui/main.rssrc/wflow_webui/server/mod.rssrc/wflow_webui/server/session.rssrc/wflow_webui/styles/main.scsssrc/wflow_webui/styles/tailwind.css
💤 Files with no reviewable changes (87)
- src/btress_api/fixtures/000_test_data.sql
- src/btress_http/request.rs
- src/tests_http/Cargo.toml
- src/daybook_http/wasmcloud.toml
- src/daybook_api/Cargo.toml
- src/granary_web/index.html
- src/wash_plugin_pglite/Cargo.toml
- src/daybook_api/wasmcloud.toml
- src/granary_web/.gitignore
- src/daybook_api/fixtures/000_test_data.sql
- src/daybook_fuse/Cargo.toml
- src/daybook_http/doc/create.rs
- src/daybook_api/migrations/versioned/m0.0.2__create_doc_tables.sql
- src/daybook_willow/Cargo.toml
- src/btress_api/Cargo.toml
- src/daybook_http/local.wadm.yaml
- src/granary_web/main.rs
- src/btress_api/migrations/r__auth_user_functions.sql
- src/tests_http/daybook.rs
- src/daybook_api/doc.rs
- src/daybook_willow/store.rs
- src/.env.test
- src/btress_http/local.wadm.yaml
- src/daybook_http/Cargo.toml
- src/tests_http/daybook/doc.rs
- src/granary_web/Cargo.toml
- src/btress_api/wasmcloud.toml
- src/granary_web/app.rs
- src/daybook_willow/lib.rs
- src/wash_plugin_mltools/lib.rs
- src/wash_plugin_mltools/Cargo.toml
- src/daybook_http/request.rs
- src/btress_api/wit/user.wit
- src/btress_http/wadm.yaml
- src/wash_plugin_pglite/wit/main.wit
- src/daybook_api/lib.rs
- src/plug_dayledger/lib.rs
- src/btress_http/wit/world.wit
- src/daybook_api/doc/create.rs
- src/daybook_fuse/lib.rs
- src/wash_plugin_pglite/plugin.rs
- src/tests_http/pg.rs
- src/wash_plugin_pglite/parse.rs
- src/daybook_wflows/lib.rs
- src/tests_http/wasmcloud.rs
- src/tests_http/sanity_http.rs
- src/wash_plugin_pglite/install.rs
- src/wash_plugin_pglite/build.rs
- src/daybook_api/migrations/versioned/m0.0.1__utils.sql
- src/daybook_server/Cargo.toml
- src/daybook_server/main.rs
- src/daybook_xilem/Cargo.toml
- src/tests_http/daybook/doc/create.rs
- src/mltools/lib.rs
- src/plug_plabels/lib.rs
- src/btress_api/wit/package.wit
- src/btress_api/user.rs
- src/daybook_api/wit/doc.wit
- src/daybook_api/bindings.rs
- src/wash_plugin_pglite/lib.rs
- src/wash_plugin_mltools/wit/main.wit
- src/daybook_http/wit/world.wit
- src/test_wflows/lib.rs
- src/macros/Cargo.toml
- src/btress_http/Cargo.toml
- src/daybook_core/Cargo.toml
- src/btress_http/lib.rs
- src/daybook_http/doc.rs
- src/macros/lib.rs
- src/granary_web/lib.rs
- src/tests_http/lib.rs
- src/daybook_http/lib.rs
- src/daybook_http/wadm.yaml
- src/btress_api/migrations/versioned/m0.0.3__create_web_table.sql
- src/tests_http/macros.rs
- src/btress_api/migrations/versioned/m0.0.1__utils.sql
- src/btress_http/wasmcloud.toml
- src/btress_api/lib.rs
- src/wash_plugin_pglite/wire.rs
- src/btress_api/migrations/versioned/m0.0.2__create_auth_tables.sql
- Cargo.toml
- src/daybook_api/wit/package.wit
- src/btress_api/user/create.rs
- src/plug_test/lib.rs
- src/daybook_api/migrations/r__doc_doc_functions.sql
- src/granary_web/app/layout.rs
- src/daybook_core/rt.rs
| ### Dead code | ||
|
|
||
| - `./src/plug_dayledger/`: personal finance plug. | ||
| The following are not in use and possibly dead code. | ||
|
|
||
| - `./src/daybook_wflows/`: wflows for daybook. | ||
| - `./src/daybook_sql/`: wit bindings for sql. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Trim the dead-code list to paths that are actually removed.
./src/daybook_wflows/ is still in the workspace member list, while ./src/daybook_sql/ is not; this subsection now mixes live and deleted paths. Please either narrow it to the removed entries or rename it to reflect historical context.
♻️ Possible fix
-### Dead code
-
-The following are not in use and possibly dead code.
-
-- `./src/daybook_wflows/`: wflows for daybook.
-- `./src/daybook_sql/`: wit bindings for sql.
+### Removed code
+
+The following path was removed in this PR:
+- `./src/daybook_sql/`: WIT bindings for SQL.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ### Dead code | |
| - `./src/plug_dayledger/`: personal finance plug. | |
| The following are not in use and possibly dead code. | |
| - `./src/daybook_wflows/`: wflows for daybook. | |
| - `./src/daybook_sql/`: wit bindings for sql. | |
| ### Removed code | |
| The following path was removed in this PR: | |
| - `./src/daybook_sql/`: WIT bindings for SQL. |
🧰 Tools
🪛 LanguageTool
[grammar] ~86-~86: Ensure spelling is correct
Context: ... dead code. - ./src/daybook_wflows/: wflows for daybook. - ./src/daybook_sql/: wi...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CONTRIBUTING.md` around lines 82 - 87, The “Dead code” subsection in
CONTRIBUTING.md is mixing a live workspace path with a removed one, so update
the list to only include paths that are actually deleted or rename the section
to clearly indicate it is historical cleanup; use the existing “Dead code”
heading and the `./src/daybook_wflows/` / `./src/daybook_sql/` entries as the
points to revise.
Source: Linked repositories
Summary by CodeRabbit