Skip to content

fix: delete dead code#31

Open
dman-os wants to merge 4 commits into
mainfrom
fix/cleanup
Open

fix: delete dead code#31
dman-os wants to merge 4 commits into
mainfrom
fix/cleanup

Conversation

@dman-os

@dman-os dman-os commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Documentation
    • Updated contributor guidance and command examples for running help output.
  • Chores
    • Simplified the workspace by removing several unused packages and dependency entries.
    • Cleaned up environment, manifest, and config files across the repo.
  • Refactor
    • Removed a large amount of unused HTTP, API, test, and plugin implementation code.
    • Streamlined build-task validation in the Android Compose app.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d6f926ff-b436-4bec-ae67-3058bba355a6

📥 Commits

Reviewing files that changed from the base of the PR and between 410b565 and 8b2d22f.

⛔ Files ignored due to path filters (2)
  • src/plug_dayledger/wit/deps/utils is excluded by !**/*/wit/deps/** and included by **/*
  • src/plug_plabels/wit/deps/utils is excluded by !**/*/wit/deps/** and included by **/*
📒 Files selected for processing (3)
  • src/daybook_compose/composeApp/build.gradle.kts
  • src/plug_dayledger/wflows/parse_hledger.rs
  • src/plug_plabels/lib.rs
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/plug_plabels/lib.rs

📝 Walkthrough

Walkthrough

This PR removes numerous crates (btress_api, btress_http, daybook_api, daybook_fuse, daybook_http, daybook_server, daybook_willow, daybook_xilem, granary_web app logic, macros, wash_plugin_mltools, wash_plugin_pglite, tests_http) along with their manifests, migrations, WIT definitions, and tests, prunes workspace membership/dependencies accordingly, unwires mltools/utils plugins from daybook_core's runtime, refactors a Gradle Android signing validation task into a typed class, adjusts parse_hledger.rs argument passing, and updates CONTRIBUTING.md.

Changes

Workspace, Plugin, and Crate Removal

Layer / File(s) Summary
Workspace membership and dependency pruning
Cargo.toml, src/daybook_core/Cargo.toml
Removes several crates from workspace members and internal path dependencies, including macros, pauperfuse, wash_plugin_mltools/utils, and wflow_ingress_http.
Runtime plugin unwiring
src/daybook_core/rt.rs
Removes utils_plugin/mltools_plugin fields, their boot-time registration, struct literal construction, and host plugin map entries.
Related module/binding cleanup
src/daybook_api/doc.rs, src/tests_http/daybook.rs, src/tests_http/daybook/doc.rs, src/mltools/lib.rs
Removes now-unused submodule declarations, a test constant, and a commented WIT import entry.
Deleted crates and generated artifacts
src/btress_api/*, src/btress_http/*, src/daybook_api/*, src/daybook_fuse/*, src/daybook_http/*, src/daybook_server/*, src/daybook_willow/*, src/daybook_xilem/Cargo.toml, src/wash_plugin_mltools/*, src/wash_plugin_pglite/*, src/tests_http/*
Deletes entire crates including manifests, lib code, migrations, fixtures, WIT contracts, wadm manifests, and tests.

granary_web Entrypoint Cleanup

Layer / File(s) Summary
Remove app module wiring and entrypoint
src/granary_web/app.rs, src/granary_web/lib.rs, src/granary_web/main.rs, src/granary_web/app/layout.rs, src/granary_web/index.html, src/granary_web/Cargo.toml, src/granary_web/.gitignore
Deletes the layout module, interlude re-exports, main() entrypoint, and associated crate/manifest content.

CONTRIBUTING.md Documentation Updates

Layer / File(s) Summary
Update guide content
CONTRIBUTING.md
Updates the help command snippet, reworks the repo guide list, and simplifies the dependency-avoidance style guide bullet.

Android Signing Validation Refactor

Layer / File(s) Summary
Typed Gradle task
src/daybook_compose/composeApp/build.gradle.kts
Introduces ValidateAndroidReleaseSigningConfigTask with @Input properties and @TaskAction, replacing the previous doLast-based validation.

Facet Creation Argument Cleanup

Layer / File(s) Summary
Update call arguments
src/plug_dayledger/wflows/parse_hledger.rs
Changes facet/tag creation calls to pass owned identifiers instead of references and renames a helper parameter.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

  • dman-os/townframe#8: Adds ML tools embedding/capability wiring that depends on the wash_plugin_mltools/utils integration removed from daybook_core's runtime in this PR.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: a cleanup that removes dead code.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CONTRIBUTING.md`:
- Around line 82-87: The “Dead code” subsection in CONTRIBUTING.md is mixing a
live workspace path with a removed one, so update the list to only include paths
that are actually deleted or rename the section to clearly indicate it is
historical cleanup; use the existing “Dead code” heading and the
`./src/daybook_wflows/` / `./src/daybook_sql/` entries as the points to revise.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9f84bf52-7935-469d-9af6-e55eec830b1f

📥 Commits

Reviewing files that changed from the base of the PR and between 98de228 and e541e7b.

⛔ Files ignored due to path filters (85)
  • Cargo.lock is excluded by !**/*.lock and included by **/*
  • src/btress_api/gen/mod.rs is excluded by !**/gen/** and included by **/*
  • src/btress_api/wasmcloud.lock is excluded by !**/*.lock and included by **/*
  • src/btress_api/wit/deps/api-utils is excluded by !**/*/wit/deps/** and included by **/*
  • src/btress_api/wit/deps/wasi-clocks-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/btress_api/wit/deps/wasi-config-0.2.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/btress_api/wit/deps/wasi-io-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/btress_api/wit/deps/wasi-keyvalue-0.2.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/btress_api/wit/deps/wasi-logging-0.1.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/btress_api/wit/deps/wasmcloud-postgres-0.1.1-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/btress_http/wasmcloud.lock is excluded by !**/*.lock and included by **/*
  • src/btress_http/wit/deps/api-utils is excluded by !**/*/wit/deps/** and included by **/*
  • src/btress_http/wit/deps/btress-api is excluded by !**/*/wit/deps/** and included by **/*
  • src/btress_http/wit/deps/wasi-cli-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/btress_http/wit/deps/wasi-clocks-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/btress_http/wit/deps/wasi-config-0.2.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/btress_http/wit/deps/wasi-http-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/btress_http/wit/deps/wasi-io-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/btress_http/wit/deps/wasi-keyvalue-0.2.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/btress_http/wit/deps/wasi-logging-0.1.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/btress_http/wit/deps/wasi-random-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/btress_http/wit/deps/wasmcloud-postgres-0.1.1-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_api/gen/mod.rs is excluded by !**/gen/** and included by **/*
  • src/daybook_api/wit/deps/api-utils is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_api/wit/deps/daybook-types is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_api/wit/deps/wasi-clocks-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_api/wit/deps/wasi-config-0.2.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_api/wit/deps/wasi-io-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_api/wit/deps/wasi-keyvalue-0.2.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_api/wit/deps/wasi-logging-0.1.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_api/wit/deps/wasmcloud-postgres-0.1.1-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_http/gen/mod.rs is excluded by !**/gen/** and included by **/*
  • src/daybook_http/wasmcloud.lock is excluded by !**/*.lock and included by **/*
  • src/daybook_http/wit/deps/api-utils is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_http/wit/deps/daybook-api is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_http/wit/deps/wasi-cli-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_http/wit/deps/wasi-clocks-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_http/wit/deps/wasi-config-0.2.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_http/wit/deps/wasi-http-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_http/wit/deps/wasi-io-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_http/wit/deps/wasi-keyvalue-0.2.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_http/wit/deps/wasi-logging-0.1.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_http/wit/deps/wasi-random-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_http/wit/deps/wasmcloud-postgres-0.1.1-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/daybook_server/gen/mod.rs is excluded by !**/gen/** and included by **/*
  • src/wash_plugin_mltools/wit/deps/api-utils is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_mltools/wit/deps/mltools is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_mltools/wit/deps/wasi-cli-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_mltools/wit/deps/wasi-clocks-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_mltools/wit/deps/wasi-config-0.2.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_mltools/wit/deps/wasi-http-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_mltools/wit/deps/wasi-io-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_mltools/wit/deps/wasi-keyvalue-0.2.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_mltools/wit/deps/wasi-logging-0.1.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_mltools/wit/deps/wasi-random-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_mltools/wit/deps/wasmcloud-postgres-0.1.1-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_pglite/wit/deps/wasi-cli-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_pglite/wit/deps/wasi-clocks-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_pglite/wit/deps/wasi-config-0.2.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_pglite/wit/deps/wasi-http-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_pglite/wit/deps/wasi-io-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_pglite/wit/deps/wasi-keyvalue-0.2.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_pglite/wit/deps/wasi-logging-0.1.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_pglite/wit/deps/wasi-random-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_utils/wit/deps/api-utils is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_utils/wit/deps/wasi-cli-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_utils/wit/deps/wasi-clocks-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_utils/wit/deps/wasi-config-0.2.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_utils/wit/deps/wasi-http-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_utils/wit/deps/wasi-io-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_utils/wit/deps/wasi-keyvalue-0.2.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_utils/wit/deps/wasi-logging-0.1.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_utils/wit/deps/wasi-random-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wash_plugin_utils/wit/deps/wasmcloud-postgres-0.1.1-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wflow_ingress_http/wit/deps/api-utils is excluded by !**/*/wit/deps/** and included by **/*
  • src/wflow_ingress_http/wit/deps/wasi-cli-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wflow_ingress_http/wit/deps/wasi-clocks-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wflow_ingress_http/wit/deps/wasi-config-0.2.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wflow_ingress_http/wit/deps/wasi-http-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wflow_ingress_http/wit/deps/wasi-io-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wflow_ingress_http/wit/deps/wasi-keyvalue-0.2.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wflow_ingress_http/wit/deps/wasi-logging-0.1.0-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wflow_ingress_http/wit/deps/wasi-random-0.2.6/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wflow_ingress_http/wit/deps/wasmcloud-postgres-0.1.1-draft/package.wit is excluded by !**/*/wit/deps/** and included by **/*
  • src/wflow_ingress_http/wit/deps/wflow is excluded by !**/*/wit/deps/** and included by **/*
📒 Files selected for processing (107)
  • CONTRIBUTING.md
  • Cargo.toml
  • src/.env.test
  • src/btress_api/Cargo.toml
  • src/btress_api/fixtures/000_test_data.sql
  • src/btress_api/lib.rs
  • src/btress_api/migrations/r__auth_user_functions.sql
  • src/btress_api/migrations/versioned/m0.0.1__utils.sql
  • src/btress_api/migrations/versioned/m0.0.2__create_auth_tables.sql
  • src/btress_api/migrations/versioned/m0.0.3__create_web_table.sql
  • src/btress_api/user.rs
  • src/btress_api/user/create.rs
  • src/btress_api/wasmcloud.toml
  • src/btress_api/wit/package.wit
  • src/btress_api/wit/user.wit
  • src/btress_http/Cargo.toml
  • src/btress_http/lib.rs
  • src/btress_http/local.wadm.yaml
  • src/btress_http/request.rs
  • src/btress_http/wadm.yaml
  • src/btress_http/wasmcloud.toml
  • src/btress_http/wit/world.wit
  • src/daybook_api/Cargo.toml
  • src/daybook_api/bindings.rs
  • src/daybook_api/doc.rs
  • src/daybook_api/doc/create.rs
  • src/daybook_api/fixtures/000_test_data.sql
  • src/daybook_api/lib.rs
  • src/daybook_api/migrations/r__doc_doc_functions.sql
  • src/daybook_api/migrations/versioned/m0.0.1__utils.sql
  • src/daybook_api/migrations/versioned/m0.0.2__create_doc_tables.sql
  • src/daybook_api/wasmcloud.toml
  • src/daybook_api/wit/doc.wit
  • src/daybook_api/wit/package.wit
  • src/daybook_core/Cargo.toml
  • src/daybook_core/rt.rs
  • src/daybook_fuse/Cargo.toml
  • src/daybook_fuse/lib.rs
  • src/daybook_http/Cargo.toml
  • src/daybook_http/doc.rs
  • src/daybook_http/doc/create.rs
  • src/daybook_http/lib.rs
  • src/daybook_http/local.wadm.yaml
  • src/daybook_http/request.rs
  • src/daybook_http/wadm.yaml
  • src/daybook_http/wasmcloud.toml
  • src/daybook_http/wit/world.wit
  • src/daybook_server/Cargo.toml
  • src/daybook_server/main.rs
  • src/daybook_wflows/lib.rs
  • src/daybook_willow/Cargo.toml
  • src/daybook_willow/lib.rs
  • src/daybook_willow/store.rs
  • src/daybook_xilem/Cargo.toml
  • src/granary_web/.gitignore
  • src/granary_web/Cargo.toml
  • src/granary_web/app.rs
  • src/granary_web/app/layout.rs
  • src/granary_web/index.html
  • src/granary_web/lib.rs
  • src/granary_web/main.rs
  • src/macros/Cargo.toml
  • src/macros/lib.rs
  • src/mltools/lib.rs
  • src/plug_dayledger/lib.rs
  • src/plug_plabels/lib.rs
  • src/plug_test/lib.rs
  • src/test_wflows/lib.rs
  • src/tests_http/Cargo.toml
  • src/tests_http/daybook.rs
  • src/tests_http/daybook/doc.rs
  • src/tests_http/daybook/doc/create.rs
  • src/tests_http/lib.rs
  • src/tests_http/macros.rs
  • src/tests_http/pg.rs
  • src/tests_http/sanity_http.rs
  • src/tests_http/wasmcloud.rs
  • src/wash_plugin_mltools/Cargo.toml
  • src/wash_plugin_mltools/lib.rs
  • src/wash_plugin_mltools/wit/main.wit
  • src/wash_plugin_pglite/Cargo.toml
  • src/wash_plugin_pglite/build.rs
  • src/wash_plugin_pglite/install.rs
  • src/wash_plugin_pglite/lib.rs
  • src/wash_plugin_pglite/parse.rs
  • src/wash_plugin_pglite/plugin.rs
  • src/wash_plugin_pglite/wire.rs
  • src/wash_plugin_pglite/wit/main.wit
  • src/wash_plugin_utils/Cargo.toml
  • src/wash_plugin_utils/lib.rs
  • src/wash_plugin_utils/wit/main.wit
  • src/wflow_ingress_http/Cargo.toml
  • src/wflow_ingress_http/lib.rs
  • src/wflow_ingress_http/request.rs
  • src/wflow_ingress_http/wit/main.wit
  • src/wflow_sdk/lib.rs
  • src/wflow_webui/Cargo.toml
  • src/wflow_webui/app.rs
  • src/wflow_webui/auth/actions.rs
  • src/wflow_webui/auth/mod.rs
  • src/wflow_webui/index.html
  • src/wflow_webui/lib.rs
  • src/wflow_webui/main.rs
  • src/wflow_webui/server/mod.rs
  • src/wflow_webui/server/session.rs
  • src/wflow_webui/styles/main.scss
  • src/wflow_webui/styles/tailwind.css
💤 Files with no reviewable changes (87)
  • src/btress_api/fixtures/000_test_data.sql
  • src/btress_http/request.rs
  • src/tests_http/Cargo.toml
  • src/daybook_http/wasmcloud.toml
  • src/daybook_api/Cargo.toml
  • src/granary_web/index.html
  • src/wash_plugin_pglite/Cargo.toml
  • src/daybook_api/wasmcloud.toml
  • src/granary_web/.gitignore
  • src/daybook_api/fixtures/000_test_data.sql
  • src/daybook_fuse/Cargo.toml
  • src/daybook_http/doc/create.rs
  • src/daybook_api/migrations/versioned/m0.0.2__create_doc_tables.sql
  • src/daybook_willow/Cargo.toml
  • src/btress_api/Cargo.toml
  • src/daybook_http/local.wadm.yaml
  • src/granary_web/main.rs
  • src/btress_api/migrations/r__auth_user_functions.sql
  • src/tests_http/daybook.rs
  • src/daybook_api/doc.rs
  • src/daybook_willow/store.rs
  • src/.env.test
  • src/btress_http/local.wadm.yaml
  • src/daybook_http/Cargo.toml
  • src/tests_http/daybook/doc.rs
  • src/granary_web/Cargo.toml
  • src/btress_api/wasmcloud.toml
  • src/granary_web/app.rs
  • src/daybook_willow/lib.rs
  • src/wash_plugin_mltools/lib.rs
  • src/wash_plugin_mltools/Cargo.toml
  • src/daybook_http/request.rs
  • src/btress_api/wit/user.wit
  • src/btress_http/wadm.yaml
  • src/wash_plugin_pglite/wit/main.wit
  • src/daybook_api/lib.rs
  • src/plug_dayledger/lib.rs
  • src/btress_http/wit/world.wit
  • src/daybook_api/doc/create.rs
  • src/daybook_fuse/lib.rs
  • src/wash_plugin_pglite/plugin.rs
  • src/tests_http/pg.rs
  • src/wash_plugin_pglite/parse.rs
  • src/daybook_wflows/lib.rs
  • src/tests_http/wasmcloud.rs
  • src/tests_http/sanity_http.rs
  • src/wash_plugin_pglite/install.rs
  • src/wash_plugin_pglite/build.rs
  • src/daybook_api/migrations/versioned/m0.0.1__utils.sql
  • src/daybook_server/Cargo.toml
  • src/daybook_server/main.rs
  • src/daybook_xilem/Cargo.toml
  • src/tests_http/daybook/doc/create.rs
  • src/mltools/lib.rs
  • src/plug_plabels/lib.rs
  • src/btress_api/wit/package.wit
  • src/btress_api/user.rs
  • src/daybook_api/wit/doc.wit
  • src/daybook_api/bindings.rs
  • src/wash_plugin_pglite/lib.rs
  • src/wash_plugin_mltools/wit/main.wit
  • src/daybook_http/wit/world.wit
  • src/test_wflows/lib.rs
  • src/macros/Cargo.toml
  • src/btress_http/Cargo.toml
  • src/daybook_core/Cargo.toml
  • src/btress_http/lib.rs
  • src/daybook_http/doc.rs
  • src/macros/lib.rs
  • src/granary_web/lib.rs
  • src/tests_http/lib.rs
  • src/daybook_http/lib.rs
  • src/daybook_http/wadm.yaml
  • src/btress_api/migrations/versioned/m0.0.3__create_web_table.sql
  • src/tests_http/macros.rs
  • src/btress_api/migrations/versioned/m0.0.1__utils.sql
  • src/btress_http/wasmcloud.toml
  • src/btress_api/lib.rs
  • src/wash_plugin_pglite/wire.rs
  • src/btress_api/migrations/versioned/m0.0.2__create_auth_tables.sql
  • Cargo.toml
  • src/daybook_api/wit/package.wit
  • src/btress_api/user/create.rs
  • src/plug_test/lib.rs
  • src/daybook_api/migrations/r__doc_doc_functions.sql
  • src/granary_web/app/layout.rs
  • src/daybook_core/rt.rs

Comment thread CONTRIBUTING.md
Comment on lines +82 to +87
### Dead code

- `./src/plug_dayledger/`: personal finance plug.
The following are not in use and possibly dead code.

- `./src/daybook_wflows/`: wflows for daybook.
- `./src/daybook_sql/`: wit bindings for sql.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Trim the dead-code list to paths that are actually removed.

./src/daybook_wflows/ is still in the workspace member list, while ./src/daybook_sql/ is not; this subsection now mixes live and deleted paths. Please either narrow it to the removed entries or rename it to reflect historical context.

♻️ Possible fix
-### Dead code
-
-The following are not in use and possibly dead code.
-
-- `./src/daybook_wflows/`: wflows for daybook.
-- `./src/daybook_sql/`: wit bindings for sql.
+### Removed code
+
+The following path was removed in this PR:
+- `./src/daybook_sql/`: WIT bindings for SQL.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
### Dead code
- `./src/plug_dayledger/`: personal finance plug.
The following are not in use and possibly dead code.
- `./src/daybook_wflows/`: wflows for daybook.
- `./src/daybook_sql/`: wit bindings for sql.
### Removed code
The following path was removed in this PR:
- `./src/daybook_sql/`: WIT bindings for SQL.
🧰 Tools
🪛 LanguageTool

[grammar] ~86-~86: Ensure spelling is correct
Context: ... dead code. - ./src/daybook_wflows/: wflows for daybook. - ./src/daybook_sql/: wi...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CONTRIBUTING.md` around lines 82 - 87, The “Dead code” subsection in
CONTRIBUTING.md is mixing a live workspace path with a removed one, so update
the list to only include paths that are actually deleted or rename the section
to clearly indicate it is historical cleanup; use the existing “Dead code”
heading and the `./src/daybook_wflows/` / `./src/daybook_sql/` entries as the
points to revise.

Source: Linked repositories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant