Skip to content

[stable] etc.linux.memoryerror: Adapt to dynamic SIGSTKSZ since glibc v2.34#22473

Merged
kinke merged 1 commit intodlang:stablefrom
kinke:memoryerror_dynamic_SIGSTKSZ
Jan 30, 2026
Merged

[stable] etc.linux.memoryerror: Adapt to dynamic SIGSTKSZ since glibc v2.34#22473
kinke merged 1 commit intodlang:stablefrom
kinke:memoryerror_dynamic_SIGSTKSZ

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented Jan 30, 2026

This fixes segfault-handler tests for LDC Linux CI, apparently caused by an insufficient alternate-stack size. Claude was able to diagnose the problem: ldc-developers/ldc#5041 (comment)

This fixes segfault-handler tests for LDC Linux CI, apparently caused
by an insufficient alternate-stack size. Claude was able to diagnose
the problem: ldc-developers/ldc#5041 (comment)
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#22473"

_SC_THREAD_ROBUST_PRIO_INHERIT,
_SC_THREAD_ROBUST_PRIO_PROTECT,
_SC_MINSIGSTKSZ,
_SC_SIGSTKSZ,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These come from my /usr/lib/x86_64-linux-gnu/bits/confname.h, glibc v2.39.

@rikkimax
Copy link
Contributor

Oh come on: ##[error]Windows Server 2019 images are now retired. For more details, see https://devblogs.microsoft.com/devops/upcoming-updates-for-azure-pipelines-agents-images

I just upgraded macos.

@rikkimax
Copy link
Contributor

Ah huh, master is all up to date, its just stable that is broken.

Heyyy @dkorpel!

Stable needs some PR's from master.

@kinke
Copy link
Contributor Author

kinke commented Jan 30, 2026

Yeah, CI fixes would ideally always target stable, and get into master by merging stable back into it.

@rikkimax
Copy link
Contributor

Let's wait on Dennis to decide. If he doesn't come back in the next day or so with a decision, I'll override the CI and merge.

All the linux runners are green, and this shouldn't touch any other OS.

@kinke
Copy link
Contributor Author

kinke commented Jan 30, 2026

Sorry, decide on what? stable's current CI problems don't block this PR at all as you pointed out. And I'd rather not have to wait for days to get this into LDC via a regular sync with stable. [Although there's https://github.com/ldc-developers/ldc/pull/5052 to check it with LDC CI, so I could merge that manual 'cherry-pick' eagerly, but it's not soo nice in the git history then.]

@rikkimax
Copy link
Contributor

Keep in mind I'm not a PR manager, so I'm acting as a backup.

@kinke kinke merged commit 737a9bf into dlang:stable Jan 30, 2026
67 of 79 checks passed
@kinke
Copy link
Contributor Author

kinke commented Jan 30, 2026

Cheers Dennis!

@kinke kinke deleted the memoryerror_dynamic_SIGSTKSZ branch January 30, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants