Draft
Conversation
Pull Request Test Coverage Report for Build 21175083179Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tackles #155
Until now, if the submitted query failed during the processing ( syntax and permission checks) then TAP didn't return the error message, just 404. The job was not created!
The clients cannot handle that properly since it's expected that every job is created on the service and it is accessible via `/tap/async/<job_id>, even if there is an error.
This PR fixes that. For every submitted query, daiquiri creates a job. The error message is now accessible. All errors that are visible in the web interface are from now on also provided in the TAP interface.
With this fix, daiquiri will produce significantly more failed jobs. In order to deal with that, every failed job gets a default destruction time and can be deleted after the time is up using the daiquiri command
vacuum_query_jobs.