Skip to content

Tap errorsummary#327

Draft
kimakan wants to merge 4 commits intodevfrom
tap-errorsummary
Draft

Tap errorsummary#327
kimakan wants to merge 4 commits intodevfrom
tap-errorsummary

Conversation

@kimakan
Copy link
Copy Markdown
Contributor

@kimakan kimakan commented Jan 7, 2026

This PR tackles #155

Until now, if the submitted query failed during the processing ( syntax and permission checks) then TAP didn't return the error message, just 404. The job was not created!
The clients cannot handle that properly since it's expected that every job is created on the service and it is accessible via `/tap/async/<job_id>, even if there is an error.

This PR fixes that. For every submitted query, daiquiri creates a job. The error message is now accessible. All errors that are visible in the web interface are from now on also provided in the TAP interface.

With this fix, daiquiri will produce significantly more failed jobs. In order to deal with that, every failed job gets a default destruction time and can be deleted after the time is up using the daiquiri command vacuum_query_jobs.

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 20, 2026

Pull Request Test Coverage Report for Build 21175083179

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 149 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.04%) to 63.739%

Files with Coverage Reduction New Missed Lines %
jobs/renderers.py 1 98.59%
jobs/models.py 10 85.53%
jobs/viewsets.py 12 94.04%
query/viewsets.py 58 67.39%
query/models.py 68 71.43%
Totals Coverage Status
Change from base Build 20263922594: 0.04%
Covered Lines: 5021
Relevant Lines: 7671

💛 - Coveralls

@kimakan kimakan marked this pull request as ready for review January 20, 2026 12:30
@kimakan kimakan marked this pull request as draft January 22, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants