Fix PDA ID insert sound not playing; Normalize PDA spans#8578
Open
flleeppyy wants to merge 3 commits intodiscordia-space:masterfrom
Open
Fix PDA ID insert sound not playing; Normalize PDA spans#8578flleeppyy wants to merge 3 commits intodiscordia-space:masterfrom
flleeppyy wants to merge 3 commits intodiscordia-space:masterfrom
Conversation
Contributor
Author
|
oh maybe i should make it so that you guys can actually uh. compile. on 516. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes inserting your ID into your PDA not making a sound.
Also normalizes spans.
Why It's Good For The Game
It irked me.
Testing
Was unable to compile on 516. I also cannot install 515
Changelog
🆑
fix: Inserting ID into PDA should make a sound now.
/:cl: