General cleanup#44
Conversation
✅ Deploy Preview for discordtickets ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Netlify preview looks good, I'll check the code a bit later but seems good to merge so far
|
|
The features page is missing from the sidebar 😕 |
I think it would be good to have one under the other instead of the current system where 'Commands' is nested in 'Features' but maybe this isn't the place to discuss that |
Fix suggested by @eartharoid
That is what 794bf2e was supposed to add, I've added cfdbc5f in order to hopefully show the Features page again but I can't accurately preview changes due to not having access to Insiders. |
eartharoid
left a comment
eartharoid
left a comment
There was a problem hiding this comment.
The documentation changes are good but I think I preferred the footer and homepage as they were
I feel including the comparison pages when they're not there yet makes the docs website feel a bit incomplete. As for the commits, mostly LGTM 👍 |
RooRay
left a comment
RooRay
left a comment
There was a problem hiding this comment.
minor adjustments but otherwise LGTM
There was a problem hiding this comment.
the new wording looks great, and the other commits are looking good too.
just one small thought, the balloons you've used in the new screenshots technically don't meet a lot of web accessibility standards for contrast and may also cause issues of people missing them because they're not as eye catching as the old red ones. i'm not sure if this is important so i'll leave it out for now (cc @eartharoid)
otherwise, looks great, thanks for your contributions! also sorry it took 4 days to review, it seems I have messed up my github notifications, whoops! this has now been fixed
| 1. Go to the `Bot` page and click `Add Bot`, then `Yes, do it!` | ||
| 2. Click `View Token`, then **copy the token and set it as your `DISCORD_TOKEN` environment variable.** | ||
| 1. Click `View Token`, then **copy the token and set it as your `DISCORD_TOKEN` environment variable.** | ||
| 2. We highly recommend disabling the "Public Bot" option to prevent other people from adding your bot to their servers. Before you can do so, you will need to go to to the `Installation` page and set `Install Link` to `None`. After saving changes, return to the `Bot` page and disable the "Public Bot" option. |
There was a problem hiding this comment.
this language is much better now
|
I was thinking the same, the new images are good but red would be better. Probably good enough though. |
3 participants
{ data-preview }must be added beside any links that require previews as there was conflict with footnote tooltip rendering when instant previews were enabled globally withnavigation.instant.preview.