Skip to content

ci: run integration tests on all PRs, not just clojure/** changes#1739

Merged
dimitri merged 3 commits into
mainfrom
ci/run-integration-on-all-prs
Jun 27, 2026
Merged

ci: run integration tests on all PRs, not just clojure/** changes#1739
dimitri merged 3 commits into
mainfrom
ci/run-integration-on-all-prs

Conversation

@dimitri

@dimitri dimitri commented Jun 25, 2026

Copy link
Copy Markdown
Owner

The workflow already includes v3 matrix targets (mssql-v3, mysql-v3, etc.) alongside v4. Restricting pull_request to clojure/** paths meant v3-only PRs (src/**) never triggered it, yet branch protection expected those check names — requiring --admin to force-merge (#1738 being the immediate example).

Change

  • pull_request: drop the paths filter entirely — every PR now runs the full matrix.
  • push: keep src/** + clojure/** + the workflow file itself, so routine non-code pushes to main do not burn the full suite.

No test code changed.

The workflow already includes v3 matrix targets (mssql-v3, mysql-v3,
etc.) alongside v4.  Restricting pull_request to clojure/** paths meant
v3-only PRs (src/**) never triggered it, yet branch protection expected
those check names — requiring --admin to force-merge.

Remove the paths filter from pull_request so the full matrix runs on
every PR.  Keep the paths filter on push so routine non-code pushes to
main (docs, CI tweaks) don't burn the full suite unnecessarily.
@dimitri
dimitri force-pushed the ci/run-integration-on-all-prs branch from f2d2e68 to 52870f1 Compare June 25, 2026 21:22
dimitri added 2 commits June 27, 2026 01:40
…T NULL fix

PR #1737 (fix for #1609) correctly suppresses DEFAULT NULL for nullable
columns with no explicit default.  ts3 and t3 in type_precision had no
explicit default in the MariaDB source, so v3 now emits no DEFAULT clause.
Update the v3.mariadb expected file to match.
Restore header padding and use '| ' (pipe-space) for empty column_default
cells, matching actual psql output format.
@dimitri
dimitri merged commit 58e98e2 into main Jun 27, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant