Conversation
6636383 to
eb4f5fb
Compare
anatoly-scherbakov
approved these changes
Dec 16, 2025
davidlehn
reviewed
Dec 16, 2025
Member
davidlehn
left a comment
There was a problem hiding this comment.
- Thanks for cleanup.
- I think much this style was originally due to manual js to py conversion.
eb4f5fb to
9fd53c5
Compare
9fd53c5 to
013c3ad
Compare
davidlehn
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes some of 'old-style' python code and fixes linter issues:
cmp()function wrt to sortingisinstance()andisto do type checking (instead of for instancetype(x) == bool)not X in YtoX not in Y