Corrected Info.plist for macOS builds - #5
Open
oryschakj wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for drawing my attention to this -- I actually did not have a macOS device until very recently, so I did not have the ability to test this. There are actually more changes I want to apply (such as fixing the icons and the build script), I'll try to get to it as soon as I can. |
Author
|
That sounds great! I'll keep an eye out for future builds and I'll be thrilled once this is running well on macOS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a couple issues with the Info.plist file that prevented EDuke32.app from executing. The corrected Info.plist references the "amcsquad" executable and adds an identifier string.
Note that AMC Squad itself still runs extremely poorly with Polymost and OpenGL on macOS but at least you can run it now :)