fix: spinners and log output no longer intermix#4090
Merged
1 commit merged intomasterfrom Jan 30, 2025
Merged
Conversation
- changed stderr logging to use a sync logger
ghost
enabled auto-merge (squash)
adamspofford-dfinity
approved these changes
Jan 30, 2025
viviveevee
pushed a commit
that referenced
this pull request
Feb 4, 2025
- changed stderr logging to use a sync logger
adamspofford-dfinity
pushed a commit
that referenced
this pull request
Feb 18, 2025
- changed stderr logging to use a sync logger
adamspofford-dfinity
pushed a commit
that referenced
this pull request
Feb 18, 2025
- changed stderr logging to use a sync logger
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Even with
self.spinners.suspend(|| self.inner.log(record, values)), spinner and log outputs would sometimes intermix. dfx doesn't have high-volume logging, so this PR changes stderr logging to use sync logging.How Has This Been Tested?
Tested on another branch that makes more use of progress bars + logging
Checklist: