feat: migrate hosting examples to icp-cli + remove svelte-starter#1303
Merged
feat: migrate hosting examples to icp-cli + remove svelte-starter#1303
Conversation
Empty Svelte template with dead Internet Identity artifacts cargo-culted from svelte-motoko-starter. No backend, no value over sveltekit-starter.
Replace dfx.json with icp.yaml, update README to use icp-cli commands.
Replace dfx.json with icp.yaml, update README to use icp-cli commands.
Replace dfx.json with icp.yaml, update README to use icp-cli commands.
Replace dfx.json with icp.yaml, migrate from Create React App to Vite, convert class component to functional React, update README to icp-cli.
Add icp-cli configuration to my_crypto_blog and react examples while keeping dfx.json for ICP Ninja compatibility. Standardize READMEs.
Add icp.yaml, switch from mainnet USDC to testnet tokens (tICP + tICRC1), add wallet session persistence across page refreshes, update dependencies (signer 4.2.2, lucide-react, prettier), fix npm audit vulnerabilities (minimatch override), standardize README structure.
Replace dfx commands with icp-cli equivalents in hosting CI workflows. Fix hosting-unity-webgl paths trigger (was pointing to motoko/ instead of hosting/).
Add icp-cli and ic-mops to both Darwin and Linux provision scripts. Existing dfx installation is unchanged — both CLIs are available.
The ninja workflow uses dfx which triggers npm run build. The prebuild lifecycle hook (npm i --include=dev) ensures deps are installed before vite runs. Also remove redundant npm install from icp.yaml since prebuild handles it.
viviveevee
approved these changes
Feb 25, 2026
Remove unused keywords frontmatter from all hosting READMEs. Reorder prerequisites so Node.js comes before icp-cli (npm needs Node first). Rename react example title to "Basic React Frontend".
icp-cli queries the GitHub API to download the network launcher, which hits the unauthenticated rate limit (60 req/hr) in CI. Pass GITHUB_TOKEN via ICP_CLI_GITHUB_TOKEN to authenticate.
icp-cli v0.1.0 doesn't support ICP_CLI_GITHUB_TOKEN yet, so `icp network start` hits the unauthenticated GitHub API rate limit (60 req/hr) when fetching the latest launcher version. Add a shared script that uses the authenticated `gh` CLI to get the version and downloads the binary directly. Sets ICP_CLI_NETWORK_LAUNCHER_PATH so icp-cli skips the API call entirely. Replaces the previous ICP_CLI_GITHUB_TOKEN approach which only works with unreleased icp-cli builds.
marc0olo
added a commit
that referenced
this pull request
Feb 25, 2026
Fix the install order to list Node.js before icp-cli, consistent with the README prerequisites. Includes hosting BUILD.md files from PR #1303.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
icp.yaml, deletedfx.json, update READMEs to icp-cli commandsicp.yamlto 3 ICP Ninja hosting examples (my_crypto_blog, react, oisy-signer-demo) while keepingdfx.jsonfor ICP Ninja compatibilitymotoko/instead ofhosting/).gitignorefor icp-cli cache directory