fix: Cleared the query string for the room view model when switching tabs#166
Draft
floormatgen wants to merge 1 commit intomainfrom
Draft
Conversation
…tabs This is a temporary solution, as the tabs should not be sharing a view model. A more permenant solution would be to use VISOR ViewModel factories.
DickoEvaldo
approved these changes
Apr 1, 2026
Contributor
DickoEvaldo
left a comment
DickoEvaldo
left a comment
There was a problem hiding this comment.
temporary fix for the issue keep the issue up on github. you already have the right idea to seperate the view model maybe you can do that after this
Collaborator
Author
|
Might ask @avdn-dev if this is already fixed in the VISOR refactor or if I should do it instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The search query for rooms is reset when leaving the rooms tab, which prevents it from affecting building room results in the buildings tab.
This is a temporary solution, as the tabs should not be sharing a view model. A more permanent solution would be to use VISOR ViewModel factories. That would be a more permanent solution.
Why
If the user entered a search query for rooms in the rooms tab, it would persist to the rooms tab as they shared a view model. By resetting the search query when the tab is switched, it can't affect room results in the Building tab.
How
Added the .onDisappear(_:) view modifier to RoomTabView, which sets the search text to an empty string.
Key checks:
Automated tests:
Manual tests:
Screenshot / Recording
N/A