add preprocessor to use plain curses header, correct setupterm prototype#32
Open
Jan200101 wants to merge 1 commit intodevshane:masterfrom
Open
add preprocessor to use plain curses header, correct setupterm prototype#32Jan200101 wants to merge 1 commit intodevshane:masterfrom
Jan200101 wants to merge 1 commit intodevshane:masterfrom
Conversation
Collaborator
|
@jamesjer Would you be up for doing a peer review on this PR? |
This was referenced Feb 22, 2026
Closed
Closed
Merged
Collaborator
Collaborator
|
I want to merge #38 ahead of this PR. Then, after merging, this PR can be rebased on |
The source code was originally designed to be used with X/Open Curses which had a unqiue header to differentiate from all the incompatible curses implementations including the one that was shipped with Ultrix. These days ncurses and PDcurses implement X/Open Curses compatible interfaces so everything is interoperable however on Ultrix curses.h and cursesX.h are two different headers which conflict so a preprocessor is needed to pick the desired header. The setupterm prototype had subtle problems, the return value was always implicitly defined to be int but since it is never used it was set to void and the third argument has always been an int* but this is not an issue at runtime. tested with: `make LIBS=-lcurses TERMFLAG="-DMORE_TERMINFO -DPLAIN_CURSES"`
justwheel
added
the
build system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source code was originally designed to be used with X/Open Curses which had a unqiue header to differentiate from all the incompatible curses implementations including the one that was shipped with Ultrix.
These days ncurses and PDcurses implement X/Open Curses compatible interfaces so everything is interoperable however on Ultrix curses.h and cursesX.h are two different headers which conflict so a preprocessor is needed to pick the desired header.
The setupterm prototype had subtle problems, the return value was always implicitly defined to be int but since it is never used it was set to void and the third argument has always been an int* but this is not an issue at runtime.
tested with:
make LIBS=-lcurses TERMFLAG="-DMORE_TERMINFO -DPLAIN_CURSES"