test(scaffold): add full first-commit e2e regression test

[ichoosetoaccept]

Refs DOT-491
Refs DOT-492
Refs DOT-493
Refs DOT-494

Summary

• Add test_first_commit_succeeds_with_prek_hooks to tests/test_template.py. Generates a fresh project, runs uv sync, git init, prek install, bash scripts/prek-autoupdate.sh, then attempts the first commit.
• Mirrors the real user flow: prek hooks may auto-fix files (formatters, lockfile sync) on the first run, abort the commit, and the user re-stages and retries. The test allows up to 2 attempts; the second must succeed.

Why

This is the single regression test that guards every fresh-scaffold bug we've fixed in this stack. Without it, future template changes can silently re-break the first-commit experience and we'd never know until a user complains.

Runs with no SKIP= — every prek hook on every freshly scaffolded file. Marked @pytest.mark.slow so it only runs in poe test-all / poe test-cov, not the fast loop.

Test plan

• Test passes locally on top of the full stack (fix: scaffolded files end with single trailing newline #306, fix(prek): keep lychee on a versioned tag after autoupdate (DOT-492) #307, fix(scaffold): ship placeholder pytest file so first commit succeeds (DOT-491) #308, fix(lychee): exclude self-referential URLs and fix stale GitHub branch-protection docs link #309)
• Test fails on main — confirmed each fix is load-bearing

[ichoosetoaccept]

This change is part of the following stack:

• fix: scaffolded files end with single trailing newline #306
  • fix(prek): keep lychee on a versioned tag after autoupdate (DOT-492) #307
    • fix(scaffold): ship placeholder pytest file so first commit succeeds (DOT-491) #308
      • fix(lychee): exclude self-referential URLs and fix stale GitHub branch-protection docs link #309
        • test(scaffold): add full first-commit e2e regression test #310 ◀

_{Change managed by git-spice.}

[linear]

DOT-491 Ship placeholder test file in scaffold — first commit fails on fresh project

DOT-492 `prek autoupdate` sets lychee rev to `nightly`, which lychee's own hook rejects

DOT-493 Post-scaffold task should enable GitHub Discussions

DOT-494 Stale `docs.github.com` branch protection URL in README.md returns 404

[greptile-apps]

Greptile Summary

Adds test_first_commit_succeeds_with_prek_hooks to TestIntegration — a slow e2e regression test that generates a fresh project, runs uv sync, initialises git, installs and autoupdates prek hooks, and then exercises the full hook chain on the first commit. The test correctly mirrors the real user flow (up to two attempts to account for hooks that auto-fix then abort) and properly strips the ambient SKIP env var so no hooks are silently bypassed during the commit step.

Confidence Score: 5/5

Safe to merge — the new test is logically correct and the only finding is a P2 style suggestion about subprocess timeouts.

All changes are confined to a single test method. The logic is sound: SKIP is correctly stripped from git_env, the two-attempt retry mirrors the real user flow accurately, and the assertions correctly distinguish first-attempt hook auto-fixes from genuine failures. The one open finding (no timeout on network-bound subprocess calls) is a reliability nicety, not a correctness issue, and consistent with the pattern used by the adjacent test_uv_sync_succeeds.

No files require special attention.

Important Files Changed

Filename	Overview
tests/test_template.py	Adds test_first_commit_succeeds_with_prek_hooks — a slow e2e regression test that mirrors the real scaffold→commit user flow; network-bound subprocess calls (uv sync, prek-autoupdate.sh, lychee hook) have no timeout, which could stall a CI runner indefinitely.

Sequence Diagram

sequenceDiagram
    participant Test as test_first_commit_succeeds
    participant Copier as copier copy -r HEAD
    participant UV as uv sync
    participant Git as git init --initial-branch=main
    participant Prek as uv run prek install
    participant AutoUpdate as bash scripts/prek-autoupdate.sh
    participant Commit as git commit (attempt N)

    Test->>Copier: generate_project(tmp_path, copier_defaults)
    Copier-->>Test: project dir
    Test->>UV: uv sync
    UV-->>Test: assert returncode==0
    Test->>Git: git init
    Git-->>Test: ok
    Test->>Prek: prek install
    Prek-->>Test: assert returncode==0
    Test->>AutoUpdate: fetch latest hook revisions
    AutoUpdate-->>Test: assert returncode==0
    loop up to 2 attempts
        Test->>Test: git add -A
        Test->>Commit: git commit (env=git_env, SKIP removed)
        alt returncode==0
            Commit-->>Test: break — success
        else attempt==1 and returncode!=0
            Commit-->>Test: hooks auto-fixed files, re-stage and retry
        else attempt==2 and returncode!=0
            Commit-->>Test: assert attempt==1 → FAIL with stdout/stderr
        end
    end

Loading

Prompt To Fix All With AI

This is a comment left during a code review.
Path: tests/test_template.py
Line: 1300-1335

Comment:
**No subprocess timeout on network-bound steps**

`uv sync`, `prek install`, and especially `bash scripts/prek-autoupdate.sh` (which fetches the latest revision for every hook repo from GitHub) can hang indefinitely if the network is slow or a host is unresponsive. Without a `timeout=` argument, `subprocess.run` will wait forever, stalling the CI runner until the job-level watchdog kills it — with no signal about which step hung.

Consider adding a generous timeout to each call (e.g. 300 s for `prek-autoupdate.sh` and `uv sync`, since they're already gated behind `@pytest.mark.slow`):

```python
autoupdate = subprocess.run(
    ["bash", "scripts/prek-autoupdate.sh"],
    cwd=project,
    capture_output=True,
    text=True,
    check=False,
    timeout=300,
)
```

Same pattern applies to `uv sync` (line 1300) and `prek install` (line 1320).

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (3): Last reviewed commit: "test(scaffold): add full first-commit e2..." | Re-trigger Greptile}