feat: show deploy status on the Firewall index via waf.list#129
Open
acoshift wants to merge 1 commit into
Open
feat: show deploy status on the Firewall index via waf.list#129acoshift wants to merge 1 commit into
acoshift wants to merge 1 commit into
Conversation
Replace the per-location waf.get fan-out with a single waf.list call and
surface a Status column so users can see when a zone is still being applied
or removed by the deployer. Pending zones show a spinner ("Deploying"/
"Removing") and the index polls waf.list every 3s (api.intervalInvalidate,
mirroring the deployment detail polling) so the spinner resolves on its own.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Deploying deploys-app--console with
|
| Latest commit: |
7670d91
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://13417938.deploys-app--console.pages.dev |
| Branch Preview URL: | https://feat-waf-status.deploys-app--console.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waf.listcall (replacing the per-locationwaf.getfan-out) and surface the deployer status.fa-spinner-thirdspinner with "Deploying" (action: create) / "Removing" (action: delete);successshows a green "Active" check;errorshows a red "Error" badge.waf.listevery 3s viaapi.intervalInvalidate(same pattern as deployment detail polling), so the spinner resolves on its own with no manual reload.waf.listhandler, includestatus/actioninwaf.get, and simulate the deployer (a freshly created location startspending/createand flips tosuccessafter the first list poll).status/actiontoApi.WafZoneand aWafZoneListresult type.Test plan
bun lint— zero errorsbun check— zero errorsbun dev:mock+ Playwright at/waf?project=acme: seed zone shows "Active"; creating a firewall for another location shows a spinner + "Deploying" that auto-resolves to "Active"; zero console errors; verified light + dark.🤖 Generated with Claude Code