fix: format wasm stack traces per W3C spec#32246
Open
bartlomieju wants to merge 1 commit intodenoland:mainfrom
Open
fix: format wasm stack traces per W3C spec#32246bartlomieju wants to merge 1 commit intodenoland:mainfrom
bartlomieju wants to merge 1 commit intodenoland:mainfrom
Conversation
…rmat Wasm stack frames should use the format `wasm-function[N]:0x<offset>` per the W3C WebAssembly Web API spec, not `line:col`. Updates the existing wasm_url test expectation and adds a new integration test covering unreachable traps, multi-frame wasm call chains, and Error.prepareStackTrace with wasm frames. Ref: denoland#32239 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wasm-function[<funcIndex>]:0x<hexOffset>instead of the genericline:colformatwasm_urltest expectation to matchwasm_stack_trace) covering:wasm-function[0]:0x<offset>formatError.prepareStackTracecallsitetoString()producing correct wasm formatFixes #32239
Test plan
cargo test specs::run::wasm_stack_trace— new test verifying all three wasm stack trace scenarioscargo test specs::run::wasm_url— existing test with updated expectationcargo test specs::run::wasm_unreachable— existing test (broad wildcards, should still pass)🤖 Generated with Claude Code