refactor: Clean up table feature parsing with strum-0.28#1925
refactor: Clean up table feature parsing with strum-0.28#1925scovich wants to merge 3 commits intodelta-io:mainfrom
Conversation
github-actions
bot
added
the
breaking-change
scovich
removed
the
breaking-change
|
Note: We shouldn't merge this unless/until we're ready to require strum-0.28 (it had been pinned at 0.27, not sure why) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1925 +/- ##
==========================================
- Coverage 86.07% 86.07% -0.01%
==========================================
Files 139 139
Lines 41286 41280 -6
Branches 41286 41280 -6
==========================================
- Hits 35538 35532 -6
Misses 4219 4219
Partials 1529 1529 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| serde = { version = "1", features = ["derive", "rc"] } | ||
| serde_json = "1" | ||
| strum = { version = "0.27", features = ["derive"] } | ||
| strum = { version = "0.28", features = ["derive"] } |
There was a problem hiding this comment.
It was pinned because of an Arrow update: https://github.com/delta-io/delta-kernel-rs/pull/885/changes#diff-45b9953e854edc633b513d9ce5dbb79628995bd5fc7f8880372d76bb4fffa0fdR48
Arrow has a PR open to bump to 0.28 as well: apache/arrow-rs#9471
If it compiles, it works, right? 🤷
There was a problem hiding this comment.
Does the arrow update allow or force 0.28? Seems like = would force it?
There was a problem hiding this comment.
It would force arrow to compile with that yeah, but as long as there's not a boundary between two crates where they try and exchange data types from a shared dependency, they can use different versions of that dependency.
| serde = { version = "1", features = ["derive", "rc"] } | ||
| serde_json = "1" | ||
| strum = { version = "0.27", features = ["derive"] } | ||
| strum = { version = "0.28", features = ["derive"] } |
There was a problem hiding this comment.
It would force arrow to compile with that yeah, but as long as there's not a boundary between two crates where they try and exchange data types from a shared dependency, they can use different versions of that dependency.
3 participants
What changes are proposed in this pull request?
Now that Peternator7/strum#476 merged, we can use From/Into instead of the bespoke
IntoTableFeaturetrait.How was this change tested?
Existing unit tests.