Skip to content

chore: Valkey - improve typing#3285

Merged
anakin87 merged 1 commit intomainfrom
valkey-fix-mypy
May 7, 2026
Merged

chore: Valkey - improve typing#3285
anakin87 merged 1 commit intomainfrom
valkey-fix-mypy

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented May 7, 2026

Related Issues

Proposed Changes:

  • improve types

How did you test it?

CI

Checklist

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Coverage report (valkey)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  integrations/valkey/src/haystack_integrations/document_stores/valkey
  document_store.py 735-742, 773-780
Project Total  

This report was generated by python-coverage-comment-action

@anakin87 anakin87 marked this pull request as ready for review May 7, 2026 08:29
@anakin87 anakin87 requested a review from a team as a code owner May 7, 2026 08:29
@anakin87 anakin87 requested review from bogdankostic and removed request for a team May 7, 2026 08:29
@anakin87 anakin87 self-assigned this May 7, 2026
Copy link
Copy Markdown
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anakin87 anakin87 merged commit 9f9a63f into main May 7, 2026
12 checks passed
@anakin87 anakin87 deleted the valkey-fix-mypy branch May 7, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants