Fix regression in object detection models#3841
Open
alanocallaghan wants to merge 6 commits into
Open
Conversation
Removed unused import statement for Arrays.
Removed comment about rescaling box coordinates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve #3840
Previously imageWidth/height was used from ObjectDetectionTranslator:
djl/api/src/main/java/ai/djl/modality/cv/translator/SingleShotDetectionTranslator.java
Lines 63 to 66 in 3cc328d
These were usually ignored/set to zero unless the rescaleRatio was set:
djl/api/src/main/java/ai/djl/modality/cv/translator/ObjectDetectionTranslator.java
Lines 81 to 92 in 3cc328d
now, width/height are used from BaseImageTranslator, and these always default to 224x224:
djl/api/src/main/java/ai/djl/modality/cv/translator/BaseImageTranslator.java
Lines 111 to 112 in 3edd20a
Currently it is possible (and indeed common) to double-normalize the coordinates in this method (if width/height are nonzero and applyRatio is true), and the default is to normalize coordinates even though they are by default normalized in the SSD models anyway; meaning the default was double normalization and triple normalization is possible. This change means that coordinates are only normalized if the applyRatio flag is set, which seems appropriate based on the documentation.