Skip to content

release: promote develop to main#200

Merged
dborgards merged 2 commits intomainfrom
develop
Mar 9, 2026
Merged

release: promote develop to main#200
dborgards merged 2 commits intomainfrom
develop

Conversation

@dborgards
Copy link
Copy Markdown
Owner

@dborgards dborgards commented Mar 9, 2026

Release Promotion

Promotes the current develop state to main to trigger the stable release pipeline.

Included scope

Pre-merge checks

  • CI checks green on develop

Post-merge

  • Stable release should be published by the configured release workflow.

Note

Low Risk
Small, targeted parsing fix plus tests; low behavioral risk beyond correcting the SubNumber=0xFF edge case.

Overview
Fixes an infinite-loop/hang when parsing EDS objects with a maximum sub-index of 0xFF by switching the ParseSubObjects loop counter from byte to int and casting only when indexing/reading sub-objects.

Adds an integration fixture (max_subnumber.eds) and a new EdsDcfNet.TestHost console probe invoked from tests with a timeout to ensure both sync and async ReadEds* paths don’t hang and correctly parse sub-objects 0x00 and 0xFF. Also bumps package version to 1.8.1-beta.1 and updates CHANGELOG.md for the release note.

Written by Cursor Bugbot for commit 4b0428f. This will update automatically on new commits. Configure here.

dborgards and others added 2 commits March 9, 2026 16:48
* fix: prevent EDS read hang on max sub index

* test: isolate EDS hang regression checks

* build: include EDS probe host in solution

---------

Co-authored-by: Dietmar <2646931+dborgards@users.noreply.github.com>
## [1.8.1-beta.1](v1.8.0...v1.8.1-beta.1) (2026-03-09)

### 🐛 Bug Fixes

* prevent EDS read hang on max sub index ([#199](#199)) ([8ba4082](8ba4082))
Copilot AI review requested due to automatic review settings March 9, 2026 15:50
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Promotes the current develop state to main for release, including the fix for an EDS parsing hang when SubNumber is 0xFF and accompanying regression coverage via an external probe.

Changes:

  • Fix sub-object parsing loop in CanOpenReaderBase.ParseSubObjects to avoid byte wraparound when the max sub-index is 0xFF.
  • Add an integration “probe” console host plus a test runner to validate sync/async reads complete within a timeout and include sub-index 0x00 and 0xFF.
  • Add a max_subnumber.eds fixture and wire up the new test host project into the test project/solution.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/EdsDcfNet.Tests/Integration/EdsReadProbeRunner.cs New helper to execute the probe process with a timeout and parse its output.
tests/EdsDcfNet.Tests/Integration/CanOpenFileTests.cs Adds sync regression test for SubNumber=0xFF hang + highest sub-object parsing.
tests/EdsDcfNet.Tests/Integration/CanOpenFileAsyncTests.cs Adds async regression test for SubNumber=0xFF hang + highest sub-object parsing.
tests/EdsDcfNet.Tests/Fixtures/max_subnumber.eds New fixture exercising max sub-index (0xFF) behavior.
tests/EdsDcfNet.Tests/EdsDcfNet.Tests.csproj Builds the probe host as part of the test build (non-referenced output).
tests/EdsDcfNet.TestHost/Program.cs New console probe that reads an EDS and prints key/value output for assertions.
tests/EdsDcfNet.TestHost/EdsDcfNet.TestHost.csproj New net10.0 test host project referencing the library.
src/EdsDcfNet/Parsers/CanOpenReaderBase.cs Core parsing fix: use int loop counter and cast only at lookup/storage.
src/EdsDcfNet/EdsDcfNet.csproj Version updated as part of release flow.
EdsDcfNet.sln Adds the new EdsDcfNet.TestHost project to the solution.
CHANGELOG.md Includes the prerelease entry corresponding to the fix.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread tests/EdsDcfNet.Tests/Integration/EdsReadProbeRunner.cs
@dborgards dborgards merged commit 4305157 into main Mar 9, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants