dbeaver/pro#8899 disable autocommit toggle for db2i#4311
Open
dbeaver/pro#8899 disable autocommit toggle for db2i#4311
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Contributor
There was a problem hiding this comment.
Pull request overview
Disables explicit auto-commit toggling during result-set batch updates for data sources that implement DBCNativeBatchAutoCommit (intended to address DB2i behavior per dbeaver/pro#8899).
Changes:
- Adds a
skipAutoCommitToggleguard to avoid callingsetAutoCommit(false)for certain data sources. - Extends the same guard to suppress explicit
commit/rollbackcalls during the batch update flow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yagudin10
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes dbeaver/pro#8899