fix(ws): filter the websockets handshake-probe traceback flood#250
Draft
emranemran wants to merge 1 commit into
Draft
fix(ws): filter the websockets handshake-probe traceback flood#250emranemran wants to merge 1 commit into
emranemran wants to merge 1 commit into
Conversation
Non-WebSocket connections to the port (health probes, port scanners, the tunnel's TCP checks) fail the WS handshake and websockets logs a full InvalidMessage/EOFError traceback — ~2k per pod per session of pure noise. They fail before `_process_request`, so the HTTP short-circuit can't catch them. Add a logging.Filter on the `websockets.server` logger that drops the `opening handshake failed` record (logged on that logger directly, no per-connection child, so one filter catches all). Real handler failures log a different message (`connection handler failed`) and still surface. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR ⚡
Non-WebSocket connections flood the log with
opening handshake failedtracebacks. Drop that one record.The noise 🔊
:8765without a valid WS request.InvalidMessage/EOFErrortraceback per hit → ~2,030 per pod per session._process_request, so the HTTP short-circuit can't catch them.The fix ✅
A small
logging.Filteron thewebsockets.serverlogger that drops records whose message is exactlyopening handshake failed. The record is logged on that logger directly (no per-connection child), so one filter catches all — traceback included.Safe by design 🛡️
connection handler failed) → still surface.Deploy note 📦
DEMON server code → needs a
:warmre-bake to hit the fleet.🤖 Generated with Claude Code