Skip to content

Null dataset collection#474

Merged
marianotepper merged 2 commits intomainfrom
null-dataset-collection
Jun 10, 2025
Merged

Null dataset collection#474
marianotepper merged 2 commits intomainfrom
null-dataset-collection

Conversation

@marianotepper
Copy link
Contributor

@marianotepper marianotepper commented Jun 10, 2025

This PR:

  • Fixes a bug where, if one of the sections in the YAML file is empty, the key in datasetNames will have a null value. In that case, DatasetCollection.load was failing.
  • Adds a YAML file for colbert-1M because its lower dimensionality was not compatible with the default 192 segments used by the other datasets

@marianotepper marianotepper requested a review from jkni June 10, 2025 15:35
@marianotepper marianotepper marked this pull request as ready for review June 10, 2025 15:38
@marianotepper marianotepper merged commit 2bf5f9a into main Jun 10, 2025
8 checks passed
@marianotepper marianotepper deleted the null-dataset-collection branch June 10, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkni jkni jkni approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marianotepper @jkni