Fix TestOnDiskGraphIndex.testReorderingWithHoles#400
Merged
marianotepper merged 3 commits intomainfrom Mar 10, 2025
Merged
Conversation
jkni
requested changes
Mar 10, 2025
Contributor
jkni
left a comment
jkni
left a comment
There was a problem hiding this comment.
One meaningful nit (closing the reader in getNodes) and two minor hygiene nits. Fix looks good to me. Thank you!
jvector-base/src/main/java/io/github/jbellis/jvector/graph/disk/OnDiskGraphIndex.java
Outdated
Show resolved
Hide resolved
jvector-base/src/main/java/io/github/jbellis/jvector/graph/disk/OnDiskGraphIndex.java
Outdated
Show resolved
Hide resolved
jvector-base/src/main/java/io/github/jbellis/jvector/graph/disk/OnDiskGraphIndex.java
Show resolved
Hide resolved
jkni
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #399 and adds an additional assertion in the test to verify the corrected OnDiskGraphIndex.getNodes.
As part of the fix, I had to serialize the idUpperBound. The side effect is that OnDiskGraphIndex is in version 4 now.