Merged
Conversation
Signed-off-by: Samuel Herman <samuelherman@macbook-pro.lan>
Signed-off-by: Samuel Herman <sherman8915@gmail.com>
Signed-off-by: Samuel Herman <sherman8915@gmail.com>
Signed-off-by: Samuel Herman <sherman8915@gmail.com>
Signed-off-by: Samuel Herman <sherman8915@gmail.com>
tlwillke
approved these changes
Feb 25, 2025
Collaborator
tlwillke
left a comment
There was a problem hiding this comment.
+1 with the rat fix and change to instructions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add JMH Benchmarking
Overview
This PR introduces a dedicated JMH benchmarking module (
benchmark-jmh) to provide basic microbenchmarking for performance measurements for jvector operations. The module enables systematic performance testing and comparison of variants of the vector search such as:Changes
benchmark-jmhmoduleRandomVectorsBenchmarkandStaticSetVectorsBenchmarkImplementation Details
Usage
Output
The output summary will look like this:
The full output will look something like this: