Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
160 changes: 160 additions & 0 deletions src/json_str_contains.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,160 @@
use std::any::Any;

use datafusion::arrow::array::BooleanArray;
use datafusion::arrow::datatypes::DataType;
use datafusion::common::{plan_err, Result};
use datafusion::logical_expr::{ColumnarValue, ScalarFunctionArgs, ScalarUDFImpl, Signature, Volatility};
use jiter::Peek;

use crate::common::{get_err, invoke, jiter_json_find, return_type_check, GetError, JsonPath};
use crate::common_macros::make_udf_function;

make_udf_function!(
JsonStrContains,
json_str_contains,
json_data path needle,
r"Checks if a JSON string value at the specified path contains the given substring"
);

#[derive(Debug, PartialEq, Eq, Hash)]
pub(super) struct JsonStrContains {
signature: Signature,
aliases: [String; 1],
}

impl Default for JsonStrContains {
fn default() -> Self {
Self {
signature: Signature::any(3, Volatility::Immutable),
aliases: ["json_str_contains".to_string()],
}
}
}

impl ScalarUDFImpl for JsonStrContains {
fn as_any(&self) -> &dyn Any {
self
}

fn name(&self) -> &str {
self.aliases[0].as_str()
}

fn signature(&self) -> &Signature {
&self.signature
}

fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> {
if arg_types.len() == 3 {
return_type_check(arg_types, self.name(), DataType::Boolean).map(|_| DataType::Boolean)
} else {
plan_err!("'json_str_contains' function requires exactly three arguments: json_data, path, and needle.")
}
}

fn invoke_with_args(&self, args: ScalarFunctionArgs) -> Result<ColumnarValue> {
invoke::<BooleanArray>(&args.args, jiter_json_str_contains)
}

fn aliases(&self) -> &[String] {
&self.aliases
}
}

fn jiter_json_str_contains(json_data: Option<&str>, path: &[JsonPath]) -> Result<bool, GetError> {
if path.len() != 2 {
return get_err!();
}

let [JsonPath::Key(path_str), JsonPath::Key(needle_str)] = path else {
return get_err!();
};

let parsed_path = path_str.split('.').map(|s| JsonPath::Key(s)).collect::<Vec<_>>();

let Some((mut jiter, Peek::String)) = jiter_json_find(json_data, &parsed_path) else {
return Ok(false);
};

let str_value = jiter.known_str()?;

Ok(str_value.contains(needle_str))
}

#[cfg(test)]
mod tests {
use super::*;
use datafusion::arrow::array::StringArray;
use datafusion::common::ScalarValue;
use datafusion::logical_expr::ColumnarValue;
use std::sync::Arc;

#[test]
fn test_json_str_contains_simple() {
let json_data = r#"{"name": "Norm Macdonald", "title": "Software Engineer"}"#;
let json_array = Arc::new(StringArray::from(vec![json_data]));

let args = vec![
ColumnarValue::Array(json_array),
ColumnarValue::Scalar(ScalarValue::Utf8(Some("name".to_string()))),
ColumnarValue::Scalar(ScalarValue::Utf8(Some("Norm".to_string()))),
];

let result = invoke::<BooleanArray>(&args, jiter_json_str_contains).unwrap();

match result {
ColumnarValue::Array(arr) => {
let bool_arr = arr.as_any().downcast_ref::<BooleanArray>().unwrap();
assert_eq!(bool_arr.len(), 1);
assert_eq!(bool_arr.value(0), true);
}
_ => panic!("Expected array result"),
}
}

#[test]
fn test_json_str_contains_not_found() {
let json_data = r#"{"name": "Norm Macdonald"}"#;
let json_array = Arc::new(StringArray::from(vec![json_data]));

let args = vec![
ColumnarValue::Array(json_array),
ColumnarValue::Scalar(ScalarValue::Utf8(Some("name".to_string()))),
ColumnarValue::Scalar(ScalarValue::Utf8(Some("Dave".to_string()))),
];

let result = invoke::<BooleanArray>(&args, jiter_json_str_contains).unwrap();

match result {
ColumnarValue::Array(arr) => {
let bool_arr = arr.as_any().downcast_ref::<BooleanArray>().unwrap();
assert_eq!(bool_arr.len(), 1);
assert_eq!(bool_arr.value(0), false);
}
_ => panic!("Expected array result"),
}
}

#[test]
fn test_json_str_contains_nested() {
let json_data = r#"{"user": {"profile": {"name": "Norm Macdonald"}}}"#;
let json_array = Arc::new(StringArray::from(vec![json_data]));

let args = vec![
ColumnarValue::Array(json_array),
ColumnarValue::Scalar(ScalarValue::Utf8(Some("user.profile.name".to_string()))),
ColumnarValue::Scalar(ScalarValue::Utf8(Some("Macdonald".to_string()))),
];

let result = invoke::<BooleanArray>(&args, jiter_json_str_contains).unwrap();

match result {
ColumnarValue::Array(arr) => {
let bool_arr = arr.as_any().downcast_ref::<BooleanArray>().unwrap();
assert_eq!(bool_arr.len(), 1);
assert_eq!(bool_arr.value(0), true);
}
_ => panic!("Expected array result"),
}
}
}
4 changes: 4 additions & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ mod json_get_json;
mod json_get_str;
mod json_length;
mod json_object_keys;
mod json_str_contains;
mod rewrite;

pub use common_union::{JsonUnionEncoder, JsonUnionValue, JSON_UNION_DATA_TYPE};
Expand All @@ -37,6 +38,7 @@ pub mod functions {
pub use crate::json_get_str::json_get_str;
pub use crate::json_length::json_length;
pub use crate::json_object_keys::json_object_keys;
pub use crate::json_str_contains::json_str_contains;
}

pub mod udfs {
Expand All @@ -52,6 +54,7 @@ pub mod udfs {
pub use crate::json_get_str::json_get_str_udf;
pub use crate::json_length::json_length_udf;
pub use crate::json_object_keys::json_object_keys_udf;
pub use crate::json_str_contains::json_str_contains_udf;
}

/// Register all JSON UDFs, and [`rewrite::JsonFunctionRewriter`] with the provided [`FunctionRegistry`].
Expand All @@ -77,6 +80,7 @@ pub fn register_all(registry: &mut dyn FunctionRegistry) -> Result<()> {
json_length::json_length_udf(),
json_object_keys::json_object_keys_udf(),
json_from_scalar::json_from_scalar_udf(),
json_str_contains::json_str_contains_udf(),
];
functions.into_iter().try_for_each(|udf| {
let existing_udf = registry.register_udf(udf)?;
Expand Down
64 changes: 64 additions & 0 deletions tests/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2677,3 +2677,67 @@ async fn test_json_from_scalar_null_column() {
];
assert_batches_eq!(expected, &batches);
}

#[tokio::test]
async fn test_json_str_contains_simple() {
let sql = r#"select json_str_contains('{"name": "Norm Macdonald"}', 'name', 'Norm')"#;
let batches = run_query(sql).await.unwrap();
assert_eq!(display_val(batches).await, (DataType::Boolean, "true".to_string()));
}

#[tokio::test]
async fn test_json_str_contains_not_found() {
let sql = r#"select json_str_contains('{"name": "Norm Macdonald"}', 'name', 'Norma')"#;
let batches = run_query(sql).await.unwrap();
assert_eq!(display_val(batches).await, (DataType::Boolean, "false".to_string()));
}

#[tokio::test]
async fn test_json_str_contains_nested() {
let sql = r#"select json_str_contains('{"user": {"profile": {"name": "Norm Macdonald"}}}', 'user.profile.name', 'Macdonald')"#;
let batches = run_query(sql).await.unwrap();
assert_eq!(display_val(batches).await, (DataType::Boolean, "true".to_string()));
}

#[tokio::test]
async fn test_json_str_contains_case_sensitive() {
let sql = r#"select json_str_contains('{"title": "Software Engineer"}', 'title', 'engineer')"#;
let batches = run_query(sql).await.unwrap();
assert_eq!(display_val(batches).await, (DataType::Boolean, "false".to_string()));

let sql = r#"select json_str_contains('{"title": "Software Engineer"}', 'title', 'Engineer')"#;
let batches = run_query(sql).await.unwrap();
assert_eq!(display_val(batches).await, (DataType::Boolean, "true".to_string()));
}

#[tokio::test]
async fn test_json_str_contains_partial_match() {
let sql = r#"select json_str_contains('{"email": "jose.aldo@example.com"}', 'email', '@example')"#;
let batches = run_query(sql).await.unwrap();
assert_eq!(display_val(batches).await, (DataType::Boolean, "true".to_string()));
}

#[tokio::test]
async fn test_json_str_contains_table() {
let expected = [
"+------------------+----------------------------------------------------------+",
"| name | json_str_contains(test.json_data,Utf8(\"foo\"),Utf8(\"ab\")) |",
"+------------------+----------------------------------------------------------+",
"| object_foo | true |",
"| object_foo_array | false |",
"| object_foo_obj | false |",
"| object_foo_null | false |",
"| object_bar | false |",
"| list_foo | false |",
"| invalid_json | false |",
"+------------------+----------------------------------------------------------+",
];

for_all_json_datatypes(async |dt| {
let batches = run_query_datatype("select name, json_str_contains(json_data, 'foo', 'ab') from test", dt)
.await
.unwrap();
assert_batches_eq!(expected, &batches);
})
.await;
}
Loading