Fix skip command to use three-part table name for HMS ALTER#4829
Open
helloahau wants to merge 1 commit into
Open
Fix skip command to use three-part table name for HMS ALTER#4829helloahau wants to merge 1 commit into
helloahau wants to merge 1 commit into
Conversation
skip_table_or_view used schema.table, which breaks on Unity Catalog-enabled SQL warehouses when the workspace default catalog is not hive_metastore. unskip_table_or_view already used table.full_name (catalog.schema.table). Use escape_sql_identifier(table.full_name) for SET TBLPROPERTIES, matching unskip. Fixes TABLE_OR_VIEW_NOT_FOUND when running: databricks labs ucx skip Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
databricks labs ucx skip --schema ... --table ...emittedALTER TABLE \schema`.`table`without thehive_metastorecatalog qualifier. On Unity Catalog-enabled SQL warehouses whose default catalog is nothive_metastore, this fails with[TABLE_OR_VIEW_NOT_FOUND]even when the row exists in UCX inventory (hive_metastore..tables`).unskip_table_or_viewalready usedtable.full_name(three-part name);skip_table_or_viewwas inconsistent.Change
escape_sql_identifier(table.full_name)inskip_table_or_viewwhen applying the skip TBLPROPERTY, matchingunskip_table_or_view.Tests
test_skip_happy_pathexpected SQL and corrected the view fixturename=view`` so it matches the skipped object.Made with Cursor