Closed
Conversation
Add new Auth tests for Databricks SP (M2M) and Azure Client Secret. This increases coverage for existing Auth types and mirrors the tests added in the Go SDK (databricks/databricks-sdk-go#1470). Tests added: - test_workspace_oauth_m2m_auth: Tests OAuth M2M auth for WorkspaceClient - test_workspace_azure_client_secret_auth: Tests Azure Client Secret auth for WorkspaceClient - test_account_oauth_m2m_auth: Tests OAuth M2M auth for AccountClient - test_account_azure_client_secret_auth: Tests Azure Client Secret auth for AccountClient Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Applied black, autoflake, and isort formatting to fix spacing issues. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
hectorcast-db
force-pushed
the
add-oidc-auth-tests
branch
from
c2e6106 to
dd68e95
Compare
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
approved these changes
Feb 10, 2026
Fix oidc_endpoints() property. The method was incorrectly returning Azure OIDC endpoints when ARM_CLIENT_ID is set, but oidc_endpoints() is never called for Azure OIDC authentication. This logic actually caused Databricks M2M OAuth to use the wrong endpoint when the user set ARM_CLIENT_ID for other purposes. NOTE: The new logic matches the behavior of the Go SDK and Java SDK. Mirrors: databricks/databricks-sdk-java#657 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Contributor
Author
|
Couldn't merge this since the tests failed (due to core logic being wrong). Added directly to the PR with the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Add new Auth tests for Databricks SP (M2M) and Azure Client Secret.
This increases coverage for existing Auth types and mirrors the tests added in the Go SDK:
databricks/databricks-sdk-go#1470
Tests added:
test_workspace_oauth_m2m_auth: Tests OAuth M2M (machine-to-machine) authentication forWorkspaceClient
test_workspace_azure_client_secret_auth: Tests Azure Client Secret authentication for WorkspaceClienttest_account_oauth_m2m_auth: Tests OAuth M2M authentication for AccountClienttest_account_azure_client_secret_auth: Tests Azure Client Secret authentication for AccountClientHow is this tested?
Run integration tests with appropriate environment variables set.
NO_CHANGELOG=true