PECOBLR-1121 Add unit tests for DatabricksArrowBuf#1161
Open
tejassp-db wants to merge 20 commits intoPECOBLR-1121/arrow-patch/stack-1from
Open
PECOBLR-1121 Add unit tests for DatabricksArrowBuf#1161tejassp-db wants to merge 20 commits intoPECOBLR-1121/arrow-patch/stack-1from
tejassp-db wants to merge 20 commits intoPECOBLR-1121/arrow-patch/stack-1from
Conversation
Add unit tests for all public API.
tejassp-db
requested review from
gopalldb,
jayantsing-db,
jprakash-db,
madhav-db,
msrathore-db,
samikshya-db and
vikrantpuppala
gopalldb
approved these changes
Jan 23, 2026
| import org.slf4j.LoggerFactory; | ||
|
|
||
| /** Test all the public API of {@code DatabricksArrowBuf}. */ | ||
| @SuppressWarnings("resource") |
Collaborator
There was a problem hiding this comment.
instead of supressing warnings, can we simply use try-with-resources in the tests
Collaborator
There was a problem hiding this comment.
we can add a test for empty buffer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add unit tests for all public API.
Testing
Add unit tests for all public API.