-
Notifications
You must be signed in to change notification settings - Fork 127
acc: make read_id.py update replacements; add replace_all.py & add_repl.py #4238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Commit: f6a8331
30 interesting tests: 17 KNOWN, 8 RECOVERED, 4 flaky, 1 SKIP
Top 22 slowest tests (at least 2 minutes):
|
pietern
approved these changes
Jan 9, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
Use #4238 to get more specific output.
Collaborator
|
Commit: ca66e13
35 interesting tests: 13 KNOWN, 12 RECOVERED, 4 FAIL, 3 BUG, 2 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
echo >> ACC_REPLSbut will automatically add _2, _3... suffixes if replacement already exist.Why
Simplify script writing.
I'd also like to remove generic NUMID and UUID replacements and rely replace_ids.py instead. Seeing IDs is sometimes necessary.
Tests
Existing tests, new selftest.