Unlocked edit mode for workspace deployed job #4193
Merged
+127
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 8cf94bb
27 interesting tests: 18 KNOWN, 5 FAIL, 3 flaky, 1 SKIP
Top 44 slowest tests (at least 2 minutes):
|
ilyakuz-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
andrewnester
approved these changes
Jan 2, 2026
bundle/env/experimental_yaml_sync.go
Outdated
|
|
||
| // ExperimentalYamlSyncVariable names the environment variable that holds the flag whether | ||
| // experimental YAML sync is enabled. | ||
| const ExperimentalYamlSyncVariable = "DATABRICKS_BUNDLE_ENABLE_EXPERIMENTAL_YAML_SYNC" |
Contributor
There was a problem hiding this comment.
nit: I think you can make it private since you're exposing a more high level ExperimentalYamlSync here anyway
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 70747c7
29 interesting tests: 10 KNOWN, 8 RECOVERED, 5 flaky, 5 FAIL, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Why
We need to unlock jobs to allow users to manually edit Workspace-deployed jobs and run the UI->YAML sync. This feature is not yet released; therefore, we need to use a flag to maintain both old and new behaviors.
Tests
Currently, only unit tests. It seems that running acceptance tests is not yet possible for DBR-specific functionality. One potential option is to skip the DBR check for the sake of testability, but the flag is more likely to be removed at some point and we will need to introduce DBR check again.
Also I will manually check that the Workspace integration works as expected