Skip to content

MAINT: bump to sparse >=0.17#318

Merged
lucascolley merged 4 commits intodata-apis:mainfrom
crusaderky:sparse_017
Jun 4, 2025
Merged

MAINT: bump to sparse >=0.17#318
lucascolley merged 4 commits intodata-apis:mainfrom
crusaderky:sparse_017

Conversation

@crusaderky
Copy link
Copy Markdown
Contributor

@crusaderky crusaderky commented Jun 4, 2025

Outstanding deficiencies, as far as array-api-extra is concerned:

CC @hameerabbasi

@hameerabbasi
Copy link
Copy Markdown

Hey! Thanks for the list of issues; we'll work through them.

Copy link
Copy Markdown
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple questions, otherwise thanks, LGTM!

Comment thread tests/test_funcs.py Outdated
xp_assert_close(actual, expect)

@pytest.mark.skip_xp_backend(Backend.SPARSE, reason="matmul with nan fillvalue")
@pytest.mark.xfail_xp_backend(Backend.SPARSE, reason="matmul with nan fillvalue")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this tracked by an issue?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is now pydata/sparse#877

Comment thread tests/test_funcs.py
@lucascolley lucascolley added this to the 0.8.1 milestone Jun 4, 2025
@lucascolley lucascolley added the maintenance general maintenance label Jun 4, 2025
@lucascolley
Copy link
Copy Markdown
Member

thanks Guido!

@lucascolley lucascolley linked an issue Jun 4, 2025 that may be closed by this pull request
@lucascolley lucascolley merged commit 8507174 into data-apis:main Jun 4, 2025
9 checks passed
@crusaderky crusaderky deleted the sparse_017 branch June 4, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance general maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MAINT: investigate sparse matmul with nan fillvalue failure MAINT: update capabilities now that sparse has added an __array_namespace_info__()

3 participants