TYP: Full annotations for Array objects#159
Merged
lucascolley merged 4 commits intodata-apis:mainfrom Mar 17, 2025
Merged
Conversation
crusaderky
commented
Mar 17, 2025
crusaderky
force-pushed
the
annotate_arrays
branch
from
6d6b13f to
885f35d
Compare
crusaderky
changed the title
Contributor
Author
|
codecov is failing because this PR modifies a couple of sparse-specific lines that the unit tests can't cover yet. |
crusaderky
force-pushed
the
annotate_arrays
branch
from
1fd155c to
5656fb9
Compare
crusaderky
force-pushed
the
annotate_arrays
branch
from
5656fb9 to
e1d8db4
Compare
Contributor
Author
|
@lucascolley rebased and ready for review |
lucascolley
reviewed
Mar 17, 2025
crusaderky
commented
Mar 17, 2025
lucascolley
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting for
array-api-typing, I changed Array to a proper Protocol.This highlighted a wealth of issues - notably, obfuscated error messages in case of lazy shapes.
Annoyingly, numpy.ndarray doesn't fit the protocol. I did not thoroughly investigate why but it looks like a Pandora's box well beyond the scope of this PR.