chore: check in healthcheck that dataset exists (INFRA-872)#30
Merged
SamuelBoerlin merged 2 commits intomainfrom Sep 10, 2025
Conversation
BalduinLandolt
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we include and create the dsp-repo dataset on start we can check that it actually exists in the healthcheck.
This will also ensure that the container is only considered fully started/running once the dataset has been created.
/$/datasetsrequires authentication, so to keep that I added ahealthcheckuser with a randomly generated password with read-only (GET only) perms for that endpoint.There would be
org.apache.jena.fuseki.authz.LocalhostFilterto restrict access only to localhost, but unfortunately Shiro doesn't allow defining multiple chains per endpoint and so this restriction would also apply for theadminuser, which won't work.