Merged
Conversation
Owner
|
Thanks a ton 🙇 That error looks odd on Windows: Checking if that's related, but any insights are highly appreciated. |
Contributor
Author
|
Thanks. That error is noted and I'll investigate that - but it's unrelated to the changes here (and would have happened anyway). So feel free to merge this, and I'll fix that on my end, or it might drop off once R4.5 is released. One or the other! |
Owner
|
Understood, thank you -- merging. |
Contributor
Author
|
@daroczig this is now fixed in nanonext, so the error will go away when the next version's released. Or you can add |
Owner
|
Fantastic, thank you very much, @shikokuchuo🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It now errors for mirai attempting to set
daemons()on the same compute profile without an explicitdaemons(0)reset.Normally packages using mirai should not set daemons themselves as per https://mirai.r-lib.org/articles/mirai.html#using-mirai-in-a-package but the use in logger is known and explicitly excepted.
Hi @daroczig I was just checking through revdeps and I realise I should have submitted this to you sooner. It's a rather niche case I think - only applicable if 2 async appenders try to use the same namespace (not even sure that's 'valid'). Thanks!