You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Helper registration can show a persistent-looking warning while macOS is still settling, or lose a newer failure during concurrent checks. This gives approval, setup progress, active-sync waits, manual remediation and failure distinct states with matching actions.
Retry preserves the saved Enable/Disable decision, Busy observations keep the last meaningful status, and helper failure details remain available in the existing opt-in feedback snapshot. These recovery improvements apply to the normal window and popover alike.
A separate small cleanup removes the existing redundant .nixmacignore binding so strict Clippy can pass.
Test Plan
Standalone helper branch: focused Rust helper, permissions and feedback suites passed (166, 12 and 8 test executions respectively).
Standalone helper branch: 38 helper/repair frontend tests and TypeScript passed.
Standalone helper branch: strict all-target Clippy with codegen passed.
Final integrated implementation: 1,404 Rust tests passed (14 ignored), 440 frontend tests passed; strict workspace Clippy with codegen, TypeScript and production frontend build passed.
CI checks complete.
Final native smoke on the rebuilt combined app, including helper Retry/Disable and recovery behavior.
The earlier combined build received a manual smoke pass. The final feedback-diagnostic changes have regression coverage; the final native build has not been retested yet. Keeping this PR as a draft for that follow-up.
Docs
No docs update needed; this repairs existing helper recovery behavior.
These stories' HTML snapshots changed. I've added screenshots + links to the changed stories below. Review them carefully then accept the changes to regenerate baselines and include them in this PR:
Alternatively, you can run bun run test:update-snapshots locally to re-generate the baselines and then push the changes to this PR.
What does this do?
The screenshots above show UI changes detected by the Storybook
snapshot tests run on this PR. Each image is the rendered output of
a Storybook story from the code in this PR branch; the snapshot
test compared it against the committed baseline in __snapshots__/ and flagged the difference.
Checking the box tells the darkmatter[bot] to regenerate the
baselines from this PR's current code and commit them directly to
this branch. The new baselines become the source of truth for
future runs — only accept after confirming the visual changes are
intentional.
Comparison baseline: the committed __snapshots__/ files on this
PR branch (carried forward from develop). Accept updates them in
place on this branch.
No Linear issue ID found in this PR's title, description, or branch name (expected something like ENG-123). Add one so this work is traceable in Linear, or add #no-linear to the PR description to acknowledge it's intentionally untracked.
⚠️
PR is marked WIP / draft — do not merge until ready for review.
⚠️
❗ Big PR (1541 lines changed). Consider splitting it into smaller, focused changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion draft: menu-bar popover/background attention #682. That PR is stacked on this branch.
Helper registration can show a persistent-looking warning while macOS is still settling, or lose a newer failure during concurrent checks. This gives approval, setup progress, active-sync waits, manual remediation and failure distinct states with matching actions.
Retry preserves the saved Enable/Disable decision, Busy observations keep the last meaningful status, and helper failure details remain available in the existing opt-in feedback snapshot. These recovery improvements apply to the normal window and popover alike.
A separate small cleanup removes the existing redundant
.nixmacignorebinding so strict Clippy can pass.Test Plan
The earlier combined build received a manual smoke pass. The final feedback-diagnostic changes have regression coverage; the final native build has not been retested yet. Keeping this PR as a draft for that follow-up.
Docs