Xing share support#77
Open
AndrewLeedham wants to merge 4 commits intodarklow:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for Xing, the German social media platform.
I added the glyph to the SVG font then generated the TTF, WOFF and EOT files based on that. Not sure if this is the process you have been using. Let me know if not.
Tried to get the share_counter working for Xing, but they don't support CORS, so would most likely need some sort of iFrame hacking to get it working. Left it out for now.
I transpiled the CSS with lessc and minified the JS with uglify.js. Not sure what settings you use for lessc, just used -x.
Updated the docs to show basic Xing examples.
Closes: #53