Consolidate client registration implementation#1503
Merged
WhitWaldo merged 16 commits intodapr:release-1.16from Apr 1, 2025
Merged
Consolidate client registration implementation#1503WhitWaldo merged 16 commits intodapr:release-1.16from
WhitWaldo merged 16 commits intodapr:release-1.16from
Conversation
… packages to reduce code duplication throughout. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…n each client type Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…mpty constructor overload in client builders. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
… other clients for consistency. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…g. implements IDisposable, primary constructors, use of generic service registration extension) Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…aming - no need to introduce a breaking change here. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…e issues identified with Dapr.Common.Tests unit tests Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
This was referenced Jan 12, 2026
This was referenced Jan 21, 2026
This was referenced Feb 2, 2026
This was referenced Feb 16, 2026
This was referenced Mar 2, 2026
This was referenced Mar 23, 2026
This was referenced Mar 30, 2026
This was referenced Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To date, we have several standalone clients from the standard
Dapr.Clientpackage and these use a common static client builder alongside separate (but similar) static extension registration methods. This PR eliminates duplicate code by introducing a common generic extension method that each of these standalone clients utilize instead of their current separate-but-identical approaches.This also consolidates how the clients are built to have them work in a consistent way through.
Dapr.Jobsnow reflects the same internalDaprJobsGrpcClientas the other client.IDisposableto do cleanup on their respectiveHttpClientinstances.Added unit tests throughout to validate everything.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: