Fix unwanted container recreation caused by label drift in staker daemon#2413
Open
Fix unwanted container recreation caused by label drift in staker daemon#2413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consensus packages were being unexpectedly restarted after installation. The ensureDockerNetworkConfigs daemon, which runs every 2 minutes, triggered docker compose up on staker packages. On its first run after install, Docker Compose detected config changes and recreated the containers.
Root cause:
In
applyUserSettings(), thedappnode.dnp.default.*labels were overwritten on every call:writeDefaultsToLabels()computes labels from the current service state in the compose file — which by the time the daemon runs already contains user-applied values (e.g. CHECKPOINT_SYNC_URL=https://...) and port normalization (9712:9712 instead of 9712:9712/tcp). These differ from the original labels written at install time, so the compose file changes, and Docker Compose sees a new service definition and recreates the container.Fix:
Reverse the spread order so existing labels are preserved:
This makes the daemon idempotent — on re-runs, the original package defaults stored in labels are preserved, the compose file stays unchanged, and docker compose up is a no-op.