Skip to content

DAOS-18705 rebuild: set rebuild flag before creating rebuild_pool_tls (#17941)#17985

Open
gnailzenh wants to merge 14 commits intorelease/2.8from
liang/b2_8_agg_epc
Open

DAOS-18705 rebuild: set rebuild flag before creating rebuild_pool_tls (#17941)#17985
gnailzenh wants to merge 14 commits intorelease/2.8from
liang/b2_8_agg_epc

Conversation

@gnailzenh
Copy link
Copy Markdown
Collaborator

@gnailzenh gnailzenh commented Apr 12, 2026 •
edited
Loading

  • set rebuild flag before creating rebuild_pool_tls, otherwise aggregation
    can progress to higher epoch than rebuild.
  • aggregation doesn't do full scan anymore after rebuild
  • fix a rpt refcount leak in rebuild_tgt_scan_handler()

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

gnailzenh and others added 6 commits April 12, 2026 18:25
@gnailzenh
DAOS-18705 rebuild: stop refreshing aggregation epoch while rebuilding
dd10d87 
- stop refreshing aggregation epoch while rebuilding
- set rebuilding flag before setting rebuild fence

Signed-off-by: Liang Zhen <gnailzenh@gmail.com>
@wangshilong @gnailzenh
refine codes
1e43784 
Signed-off-by: Wang Shilong <shilong.wang@hpe.com>
@gnailzenh
DAOS: code cleanup
1ca300e 
Signed-off-by: Liang Zhen <gnailzenh@gmail.com>
@gnailzenh
DAOS: remove unused epoch
8ef2f7f 
Signed-off-by: Liang Zhen <gnailzenh@gmail.com>
@gnailzenh
DAOS: fix the ds_pool refcount
2a4efe4 
Signed-off-by: Liang Zhen <gnailzenh@gmail.com>
@gnailzenh
DAOS: remove false assertion
b9e335e 
Signed-off-by: Liang Zhen <gnailzenh@gmail.com>
@gnailzenh gnailzenh requested review from a team as code owners April 12, 2026 10:27
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 12, 2026

Ticket title is 'DAOS 2.6.5: Interrupt rebuild with reintegration and interrupt with exclude with active IO'
Status is 'In Progress'
Labels: 'test_2.6.5,testp1'
https://daosio.atlassian.net/browse/DAOS-18705

@gnailzenh
DAOS: more code cleanup
e0dba66 
Signed-off-by: Liang Zhen <gnailzenh@gmail.com>
@gnailzenh
DAOS: clang format fix
4c2cbfc 
Signed-off-by: Liang Zhen <gnailzenh@gmail.com>
@gnailzenh
DAOS: revert the epoch range change
7dca9f9 
Signed-off-by: Liang Zhen <gnailzenh@gmail.com>
@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Apr 14, 2026

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17985/2/execution/node/1244/log

@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Apr 15, 2026

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17985/2/execution/node/1370/log

@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Apr 15, 2026

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17985/2/execution/node/1360/log

@gnailzenh
DAOS: fix the wait condition in rebuild_tgt_fini
9d56c5b 
Signed-off-by: Liang Zhen <gnailzenh@gmail.com>
@gnailzenh gnailzenh added approved-to-merge PR has received release branch merge approval priority Ticket has high priority (automatically managed) labels Apr 15, 2026
@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Apr 15, 2026

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17985/3/execution/node/1326/log

@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Apr 15, 2026

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17985/3/execution/node/1306/log

@wangshilong
Fix rpt wakeup and assertion
5f1647d 
Signed-off-by: Wang Shilong <shilong.wang@hpe.com>
@github-actions github-actions Bot removed the priority Ticket has high priority (automatically managed) label Apr 16, 2026
@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Apr 19, 2026

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17985/8/testReport/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liuxuezhao liuxuezhao liuxuezhao approved these changes

@wangshilong wangshilong wangshilong approved these changes

@NiuYawei NiuYawei NiuYawei approved these changes

Assignees

No one assigned

Labels

approved-to-merge PR has received release branch merge approval

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gnailzenh @daosbuild3 @liuxuezhao @wangshilong @NiuYawei