support public-URL, other than "http://localhost:8080"#29
support public-URL, other than "http://localhost:8080"#29am-jo-zt wants to merge 1 commit intodanxfisher:masterfrom
Conversation
(cherry picked from commit 039a16f)
|
After updating the socket component, I'm not sure I can think of a use case for this. Correct me if I'm wrong, but after thinking about it, the socket will always be listening to |
|
Hosted on the same server maybe/probably, but not necessarily loaded on the same device. We had this application deployed to a OpenShift platform and loaded on TV screens across the office. Thus, the host (which was compiled into the code, as far as I can remember) was not |
|
Hmm. I have to investigate more. I typically just spin up a Ubuntu VM and test from a few different devices I have laying around the house. Not familiar with OpenShift but this may have something to do with the way it silos the node apps. In the most recent version, I removed the endpoint entirely from the config. Can you see if that works with OpenShift? |
|
Unfortunately this setup does not exist on our side anymore, that's why I can't test this. But as far as I can remember, the URL (including the host) has been compiled into the built sources somewhere and that was not working as we opened the app in the browsers on the TV screens and tried to navigate through it. |
2 participants
(cherry picked from commit 039a16f)