Skip to content

Add support to open NIfTI assets in Neurosift #2700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kabilar wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support to open NIfTI assets in Neurosift #2700

kabilar wants to merge 1 commit into from
+13 −1

Conversation

@kabilar
Copy link
Member

@kabilar kabilar commented Jan 23, 2026 •
edited
Loading

@kabilar kabilar requested a review from waxlamp January 23, 2026 20:15
@kabilar kabilar self-assigned this Jan 23, 2026
satra
satra reviewed Jan 23, 2026
View reviewed changes
web/src/utils/externalServices.ts
{
name: "Neurosift",
regex: /\.nii(\.gz)?$/,
maxsize: Infinity,
Copy link
Member

@satra satra Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be limited by size? usually large nifti's cannot be loaded due to memory constraints.

Copy link
Member Author

@kabilar kabilar Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just letting the user decide to load it or not, since Neurosift provides the following dialog:
image

Copy link
Member

@satra satra Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kabilar - perhaps we should add note in neurosift that certain large files may not load.

Copy link
Member Author

@kabilar kabilar Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @satra, would updating the above statement to the following work?

Warning: Loading large files may impact performance or fail to load.

Copy link
Member Author

@kabilar kabilar Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I drafted flatironinstitute/neurosift#372.

Copy link
Collaborator

@CodyCBakerPhD CodyCBakerPhD Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#372 has been merged!

Copy link
Contributor

@magland magland Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be flatironinstitute/neurosift#372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@satra satra satra left review comments

@waxlamp waxlamp Awaiting requested review from waxlamp

+2 more reviewers

@magland magland magland left review comments

@CodyCBakerPhD CodyCBakerPhD CodyCBakerPhD left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@kabilar kabilar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kabilar @satra @magland @CodyCBakerPhD