-
Notifications
You must be signed in to change notification settings - Fork 51
feat(menu-sheet): replace dialog with drawer headless, remove close button #1301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
junghyeonsu
wants to merge
14
commits into
dev
Choose a base branch
from
claude/busy-noether
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
748b082
feat(menu-sheet): replace dialog with drawer headless, remove close b…
junghyeonsu 40f6980
feat(menu-sheet): deprecate CloseButton, update registry example
junghyeonsu 8e130aa
fix(drawer): move role="dialog" boundary check outside scrollable block
junghyeonsu 577c6df
feat(menu-sheet): add Handle, showHandle/showCloseButton, fix drag, u…
junghyeonsu 6558f50
Merge branch 'dev' into claude/busy-noether
junghyeonsu 23c9406
fix(menu-sheet): remove direct MenuSheetHandle re-export for consistency
junghyeonsu 99891a0
fix(menu-sheet): swap defaults showHandle=true, showCloseButton=false
junghyeonsu df8c7d8
feat(menu-sheet)!: remove CloseButton, default showHandle=true
junghyeonsu cf0ba5a
changeset
junghyeonsu 0c00dad
feat(rootage): add header.paddingTop to menu-sheet for handle spacing
junghyeonsu b3b23fc
deprecate(rootage): mark menu-sheet-close-button as deprecated
junghyeonsu 24a9e82
docs(rootage): update deprecated messages for close button specs
junghyeonsu 0486e6a
chore: regenerate files after menu-sheet rootage changes
junghyeonsu ac0b387
feat(menu-sheet): add header paddingTop to recipe for handle spacing
junghyeonsu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| "@seed-design/react-drawer": minor | ||
| "@seed-design/react": minor | ||
| "@seed-design/css": minor | ||
| --- | ||
|
|
||
| (BREAKING CHANGE: MenuSheet snippet을 다시 설치해야 합니다.) MenuSheet에서 CloseButton을 제거하고 Handle을 추가합니다. | ||
|
|
||
| - `MenuSheet.CloseButton`, `MenuSheetCloseButton` export 제거 | ||
| - `MenuSheet.Handle` 컴포넌트 추가 (bottom-sheet-handle recipe 재사용) | ||
| - `MenuSheetTitle`에서 `useDrawerContext` 의존 제거 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import { IconEyeSlashLine } from "@karrotmarket/react-monochrome-icon"; | ||
| import { useState } from "react"; | ||
| import { ActionButton } from "seed-design/ui/action-button"; | ||
| import { | ||
| MenuSheetContent, | ||
| MenuSheetGroup, | ||
| MenuSheetItem, | ||
| MenuSheetRoot, | ||
| } from "seed-design/ui/menu-sheet"; | ||
|
|
||
| const MenuSheetControlled = () => { | ||
| const [open, setOpen] = useState(false); | ||
|
|
||
| const scheduleOpen = () => { | ||
| setTimeout(() => { | ||
| setOpen(true); | ||
| }, 1000); | ||
| }; | ||
|
|
||
| return ( | ||
| <> | ||
| <ActionButton variant="neutralSolid" onClick={scheduleOpen}> | ||
| 1초 후 열기 | ||
| </ActionButton> | ||
| <MenuSheetRoot open={open} onOpenChange={setOpen}> | ||
| <MenuSheetContent title="Actions" aria-label="Menu Sheet"> | ||
|
junghyeonsu marked this conversation as resolved.
|
||
| <MenuSheetGroup> | ||
| <MenuSheetItem label="Action 1" prefixIcon={<IconEyeSlashLine />} /> | ||
| <MenuSheetItem label="Action 2" prefixIcon={<IconEyeSlashLine />} /> | ||
| <MenuSheetItem label="Action 3" prefixIcon={<IconEyeSlashLine />} /> | ||
| </MenuSheetGroup> | ||
| </MenuSheetContent> | ||
| </MenuSheetRoot> | ||
| </> | ||
| ); | ||
| }; | ||
|
|
||
| export default MenuSheetControlled; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import { IconEyeSlashLine } from "@karrotmarket/react-monochrome-icon"; | ||
| import { useState } from "react"; | ||
| import { ActionButton } from "seed-design/ui/action-button"; | ||
| import { | ||
| MenuSheetContent, | ||
| MenuSheetGroup, | ||
| MenuSheetItem, | ||
| MenuSheetRoot, | ||
| MenuSheetTrigger, | ||
| } from "seed-design/ui/menu-sheet"; | ||
|
|
||
| const MenuSheetDismissible = () => { | ||
| const [open, setOpen] = useState(false); | ||
|
|
||
| return ( | ||
| <MenuSheetRoot open={open} onOpenChange={setOpen} dismissible={false}> | ||
| <MenuSheetTrigger asChild> | ||
| <ActionButton variant="neutralSolid">Open</ActionButton> | ||
| </MenuSheetTrigger> | ||
| <MenuSheetContent title="Actions" aria-label="Menu Sheet"> | ||
|
junghyeonsu marked this conversation as resolved.
|
||
| <MenuSheetGroup> | ||
| <MenuSheetItem | ||
| label="Action 1" | ||
| prefixIcon={<IconEyeSlashLine />} | ||
| onClick={() => setOpen(false)} | ||
| /> | ||
| <MenuSheetItem | ||
| label="Action 2" | ||
| prefixIcon={<IconEyeSlashLine />} | ||
| onClick={() => setOpen(false)} | ||
| /> | ||
| <MenuSheetItem | ||
| label="닫기" | ||
| prefixIcon={<IconEyeSlashLine />} | ||
| tone="critical" | ||
| onClick={() => setOpen(false)} | ||
| /> | ||
| </MenuSheetGroup> | ||
| </MenuSheetContent> | ||
| </MenuSheetRoot> | ||
| ); | ||
| }; | ||
|
|
||
| export default MenuSheetDismissible; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import { IconEyeSlashLine } from "@karrotmarket/react-monochrome-icon"; | ||
| import { useState } from "react"; | ||
| import { ActionButton } from "seed-design/ui/action-button"; | ||
| import { | ||
| MenuSheetContent, | ||
| MenuSheetGroup, | ||
| MenuSheetItem, | ||
| MenuSheetRoot, | ||
| MenuSheetTrigger, | ||
| } from "seed-design/ui/menu-sheet"; | ||
|
|
||
| const MenuSheetShowHandle = () => { | ||
| const [isSheetOpen, setIsSheetOpen] = useState(false); | ||
|
|
||
| return ( | ||
| <MenuSheetRoot open={isSheetOpen} onOpenChange={setIsSheetOpen}> | ||
| <MenuSheetTrigger asChild> | ||
| <ActionButton variant="neutralSolid">Open</ActionButton> | ||
| </MenuSheetTrigger> | ||
| <MenuSheetContent title="Actions" aria-label="Menu Sheet" showHandle={false}> | ||
| <MenuSheetGroup> | ||
| <MenuSheetItem label="Action 1" prefixIcon={<IconEyeSlashLine />} /> | ||
| <MenuSheetItem label="Action 2" prefixIcon={<IconEyeSlashLine />} /> | ||
| <MenuSheetItem label="Action 3" prefixIcon={<IconEyeSlashLine />} /> | ||
| </MenuSheetGroup> | ||
| </MenuSheetContent> | ||
| </MenuSheetRoot> | ||
| ); | ||
| }; | ||
|
|
||
| export default MenuSheetShowHandle; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import { IconEyeSlashLine } from "@karrotmarket/react-monochrome-icon"; | ||
| import { ActionButton } from "seed-design/ui/action-button"; | ||
| import { | ||
| MenuSheetContent, | ||
| MenuSheetGroup, | ||
| MenuSheetItem, | ||
| MenuSheetRoot, | ||
| MenuSheetTrigger, | ||
| } from "seed-design/ui/menu-sheet"; | ||
|
|
||
| const MenuSheetTriggerExample = () => { | ||
| return ( | ||
| <MenuSheetRoot> | ||
| <MenuSheetTrigger asChild> | ||
| <ActionButton variant="neutralSolid">Open</ActionButton> | ||
| </MenuSheetTrigger> | ||
| <MenuSheetContent title="Actions" aria-label="Menu Sheet"> | ||
| <MenuSheetGroup> | ||
| <MenuSheetItem label="Action 1" prefixIcon={<IconEyeSlashLine />} /> | ||
| <MenuSheetItem label="Action 2" prefixIcon={<IconEyeSlashLine />} /> | ||
| <MenuSheetItem label="Action 3" prefixIcon={<IconEyeSlashLine />} /> | ||
| </MenuSheetGroup> | ||
| </MenuSheetContent> | ||
| </MenuSheetRoot> | ||
| ); | ||
| }; | ||
|
|
||
| export default MenuSheetTriggerExample; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.