Publish wheels for Python 3.12+ using abi3#14
Open
kampersanda wants to merge 9 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the packaging and CI configuration for python-vibrato to publish a single cp38-abi3 wheel per platform (usable across newer CPython versions), while also aligning docs/examples and fixing iterator behavior in the PyO3 bindings.
Changes:
- Enable PyO3
abi3-py38and setrequires-python >= 3.8/dynamic = ["version"]for maturin-based builds. - Update GitHub Actions CI to test newer Python versions and build release artifacts once per platform/arch.
- Fix
TokenIteratorto implement__iter__, and refresh doctest version strings.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/lib.rs |
Adds TokenIterator.__iter__ to satisfy Python iterator protocol. |
Cargo.toml |
Enables PyO3 abi3-py38 for stable ABI wheels. |
pyproject.toml |
Updates maturin build requirement, declares dynamic version, and sets requires-python. |
README.md |
Updates doctest version string. |
docs/source/examples.rst |
Updates doctest version string. |
.gitignore |
Ignores Rust build artifacts and lockfile. |
.github/workflows/CI.yml |
Expands Python test matrix and revises release packaging steps/artifact naming. |
Comments suppressed due to low confidence (1)
.github/workflows/CI.yml:147
- The release job downloads artifacts without specifying an output
path. Depending ondownload-artifactdefaults, this can create per-artifact subdirectories and make the later upload glob (*) brittle (e.g., attempting to upload directories). Consider downloading everything into a dedicated directory (likedist/) withmerge-multiple: true, and uploadingdist/*explicitly.
- uses: actions/download-artifact@v4
with:
name: sdist
- uses: actions/download-artifact@v4
with:
pattern: wheels-*
merge-multiple: true
- name: Publish to PyPI
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
vbkaisetsu
reviewed
May 23, 2026
vbkaisetsu
reviewed
May 24, 2026
| with: | ||
| command: upload | ||
| args: --skip-existing * | ||
| run: uv publish --trusted-publishing always |
Member
There was a problem hiding this comment.
Did you confirm the behavior of this command?
uv publish uploads dist/* by default, but it looks like artifacts are downloaded under dist/wheels-*/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates packaging and CI so vibrato can publish wheels usable on Python 3.12, 3.13, and 3.14.
It switches the extension module to PyO3 abi3 with a minimum supported Python version of 3.10, allowing one cp310-abi3 wheel to work across supported CPython versions instead of building a separate wheel for each minor version.
Changes
pyo3abi3-py310requires-python = ">=3.10"dynamic = ["version"]formaturinmaturinbuild requirement to>=1,<2setup-pythonfrom thesdistjobcheckout@v6andsetup-python@v6maturin uploadtouv publishwith Trusted PublishingTokenIteratorto fully implement the Python iterator protocol0.5.1to0.5.2Requests