Draft
Conversation
This patch is based on a draft from Roman Lebedev.
This decompressor is ported from libraw. Some of the file handling logic has been replaced by rawspeed::Buffer and derived classes. Most of the code is untouched.
This decoder contains the logic to parse a CR3 ISOBMFF file.
…COMMENDEDEXPOSUREINDEX
IAD1 contains 4 definitions for rectangles: * crop rectangle * left optical black area rectangle * top optical black area rectangle * active area rectangle This patch parses all IAD1 rectangles and uses them for black areas and crop.
* Canon EOS 250D * Canon EOS M6 Mark II * Canon EOS M200 * Canon EOS M50 Mark II * Canon PowerShot G5 X Mark II * Canon PowerShot G7 X Mark III
This patch is based on a draft from Roman Lebedev.
cytrinox
force-pushed
the
canon_cr3
branch
3 times, most recently
from
613dd16 to
09ca1df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I compiled with
cmake .. -DALLOW_DOWNLOADING_GOOGLETEST=ON -DUSE_CLANG_TIDY=ON. There are still diagnostics from CrXDecompressor.cpp, mainly because of raw pointers and a couple of big functions. I suppose we should use the rawspeed containers for the first kind of diagnostics, but I am not familiar with them so I am open to suggestions.