fix: No longer display tags on stderr data in component testing#33400
Merged
cacieprins merged 25 commits intodevelopfrom Mar 3, 2026
Merged
fix: No longer display tags on stderr data in component testing#33400cacieprins merged 25 commits intodevelopfrom
stderr data in component testing#33400cacieprins merged 25 commits intodevelopfrom
Conversation
stderr data in component testingstderr data in component testing
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
fix/ct-stderr-tags-in-prod
|
| Run status |
|
| Run duration | 18m 57s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
12
|
|
|
1112
|
|
|
0
|
|
|
27188
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
61.04%
|
|
|---|---|
|
|
28
|
|
|
47
|
Accessibility
99.03%
|
|
|---|---|
|
|
0 critical
3 serious
1 moderate
0 minor
|
|
|
18
|
…source stream if writable
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
mschile
reviewed
Feb 27, 2026
Contributor
|
I don't know if this fixes the case with e2e testing as well |
mschile
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
When Cypress intentionally writes to
stderr, it tags the content so that it will be preserved and written to the top levelstderr. The@packages/stderr-filteringpackage takes care of tagging data and filtering the tags (and untagged data) from thestderrstream. This prevents benignstderrmessages from Electron from surfacing.In component testing
runmode with webpack 5, the out stream was getting tagged. Unfortunately, that entrypoint to the binary was not captured by the filtering part of@packages/stderr-filtering.This moves
filterstreaming from@packages/electronto the spawn logic in@packages/cli, ensuring it wraps the outermost process and filters any tags that come throughstderr.Note
Medium Risk
Changes the CLI’s child-process
stderrpiping and introduces packaging-time dependency filtering, which could affect runtime logging/diagnostics and CLI bundling if misconfigured. Also adjusts system-test dependency resolution and fixtures, which may impact CI install behavior for test projects.Overview
Prevents internal
stderrtagging noise from leaking into user-facing CLI output by routing spawned Cypress processstderrthrough@packages/stderr-filteringincli/lib/exec/spawn.ts(with pass-through behavior in dev/debug/logging modes).Updates CLI packaging to include
@packages/stderr-filteringfor bundling while stripping all@packages/*entries from the publishedcli/build/package.json.System tests now reference
cypressfromcli/buildand the dep-installer resolvesfile:workspace deps to absolute paths relative to the project, with lockfiles updated accordingly.Written by Cursor Bugbot for commit 0f5aa8f. This will update automatically on new commits. Configure here.
Steps to test
yarn binary-build(choose: overwrite)yarn binary-package [--skipSigning, if on osx]cypress-component-testing-apps: https://github.com/cypress-io/cypress-component-testing-apps/tree/main/react-webpack5-jsCYPRESS.STDERRtags in the output streamHow has the user experience changed?
PR Tasks
cypress-documentation?type definitions?