feat(other): add PHP extension dependency checking with user warnings for required and logs for optional#1830
Open
IrAlfred wants to merge 1 commit intocypht-org:masterfrom
Open
Conversation
kroky
reviewed
Jan 14, 2026
| $environment->load(); | ||
|
|
||
| /* check dependencies */ | ||
| $environment->check_dependencies(); |
Member
There was a problem hiding this comment.
Let's do this in config_gen or something that sets up the site rather than on each and every web request.
kroky
reviewed
Jan 14, 2026
| 'openssl' => 'openssl (required for encryption and secure connections)', | ||
| 'session' => 'session (required for session management)', | ||
| 'xml' => 'XML (required for HTMLPurifier, Gmail contacts, CardDAV, and feeds)', | ||
| 'dom' => 'DOM (required for HTMLPurifier and XML processing)', |
Member
There was a problem hiding this comment.
Are you sure we are using all of those extensions?
Member
Author
There was a problem hiding this comment.
They may change depending on which modules are activated. Let me investigate more deeply
kroky
reviewed
Jan 14, 2026
| if (!class_exists('Redis')) { | ||
| Hm_Debug::add('Optional PHP extension missing: redis - Redis caching or sessions will not work', 'warning'); | ||
| } | ||
| if (!class_exists('Memcached')) { |
Member
There was a problem hiding this comment.
Some of these are false-positive warnings. It might be worth checking the actually enabled modules and session config to see if these modules would cause conflicts or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #555